From c308ca09e5018aecd9ee409d6fdddb0d18d3a3de Mon Sep 17 00:00:00 2001 From: Christopher O'Connell Date: Fri, 18 Oct 2019 01:50:02 -0400 Subject: [PATCH] 1011: Fixed all of the SonarCloud blocking errors (#1017) * 1011: Added the method to the RequestMapping annotation * 1011: Changed all of the a href blank targets to include rel="noopener noreferrer" --- .../aggregator/microservices/Aggregator.java | 9 +++++---- .../java/com/iluwatar/api/gateway/ApiGateway.java | 5 +++-- .../webapp/src/main/webapp/about/index.html | 12 ++++++------ 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java b/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java index cd30afc48..ccbe6f2fe 100644 --- a/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java +++ b/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java @@ -22,11 +22,12 @@ */ package com.iluwatar.aggregator.microservices; -import org.springframework.web.bind.annotation.RequestMapping; -import org.springframework.web.bind.annotation.RestController; - import javax.annotation.Resource; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; +import org.springframework.web.bind.annotation.RestController; + /** * The aggregator aggregates calls on various micro-services, collects * data and further publishes them under a REST endpoint. @@ -47,7 +48,7 @@ public class Aggregator { * * @return a Product. */ - @RequestMapping("/product") + @RequestMapping(path = "/product", method = RequestMethod.GET) public Product getProduct() { Product product = new Product(); product.setTitle(informationClient.getProductTitle()); diff --git a/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ApiGateway.java b/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ApiGateway.java index cbabad1e6..dc4249c6e 100644 --- a/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ApiGateway.java +++ b/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ApiGateway.java @@ -23,6 +23,7 @@ package com.iluwatar.api.gateway; import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.bind.annotation.RestController; import javax.annotation.Resource; @@ -43,7 +44,7 @@ public class ApiGateway { * Retrieves product information that desktop clients need * @return Product information for clients on a desktop */ - @RequestMapping("/desktop") + @RequestMapping(path = "/desktop", method = RequestMethod.GET) public DesktopProduct getProductDesktop() { DesktopProduct desktopProduct = new DesktopProduct(); desktopProduct.setImagePath(imageClient.getImagePath()); @@ -55,7 +56,7 @@ public class ApiGateway { * Retrieves product information that mobile clients need * @return Product information for clients on a mobile device */ - @RequestMapping("/mobile") + @RequestMapping(path = "/mobile", method = RequestMethod.GET) public MobileProduct getProductMobile() { MobileProduct mobileProduct = new MobileProduct(); mobileProduct.setPrice(priceClient.getPrice()); diff --git a/naked-objects/webapp/src/main/webapp/about/index.html b/naked-objects/webapp/src/main/webapp/about/index.html index 176bfc13a..e929c5b6d 100644 --- a/naked-objects/webapp/src/main/webapp/about/index.html +++ b/naked-objects/webapp/src/main/webapp/about/index.html @@ -82,12 +82,12 @@ th, td {

This app has been generated using Apache Isis' - SimpleApp archetype, + SimpleApp archetype, to create a purposefully minimal application that nevertheless includes fixture data, integration tests and BDD specs.

- The app itself consists of a single domain class, SimpleObject, - along with an equally simple (factory/repository) domain service, SimpleObjects. + The app itself consists of a single domain class, SimpleObject, + along with an equally simple (factory/repository) domain service, SimpleObjects.

To access the app:

@@ -98,8 +98,8 @@ th, td {

provides accesses to a generic UI for end-users, - Isis' Wicket Viewer. - As its name suggests, this viewer is built on top of Apache Wicket™. + Isis' Wicket Viewer. + As its name suggests, this viewer is built on top of Apache Wicket™.

  • @@ -118,7 +118,7 @@ th, td {

    The default user/password is sven/pass (as configured in the - shiro.ini file). + shiro.ini file).