gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #563 from sunilmogadati/SonarQubeBlockerBugs

Browse Source 
#507 SonarQube blocker severity bugs
This commit is contained in:
Ilkka Seppälä
2017-04-16 08:13:26 +03:00
committed by GitHub
parent 073d06c0ae 60ebcc56f8
commit cd54cf5512
7 changed files with 38 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
service-layer/src/main/java/com/iluwatar/servicelayer/common/DaoBaseImpl.java
View File

@ -27,6 +27,7 @@ import java.util.List;
import org.hibernate.Criteria;
import org.hibernate.Session;
import org.hibernate.SessionFactory;
import org.hibernate.Transaction;
import org.hibernate.criterion.Restrictions;
@ -45,13 +46,17 @@ public abstract class DaoBaseImpl<E extends BaseEntity> implements Dao<E> {
protected Class<E> persistentClass = (Class<E>) ((ParameterizedType) getClass()
.getGenericSuperclass()).getActualTypeArguments()[0];
protected Session getSession() {
return HibernateUtil.getSessionFactory().openSession();
/*
* Making this getSessionFactory() instead of getSession() so that it is the responsibility
* of the caller to open as well as close the session (prevents potential resource leak).
*/
protected SessionFactory getSessionFactory() {
return HibernateUtil.getSessionFactory();
}
@Override
public E find(Long id) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
E result = null;
try {
@ -73,7 +78,7 @@ public abstract class DaoBaseImpl<E extends BaseEntity> implements Dao<E> {
@Override
public void persist(E entity) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
try {
tx = session.beginTransaction();
@ -91,7 +96,7 @@ public abstract class DaoBaseImpl<E extends BaseEntity> implements Dao<E> {
@Override
public E merge(E entity) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
E result = null;
try {
@ -111,7 +116,7 @@ public abstract class DaoBaseImpl<E extends BaseEntity> implements Dao<E> {
@Override
public void delete(E entity) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
try {
tx = session.beginTransaction();
@ -129,7 +134,7 @@ public abstract class DaoBaseImpl<E extends BaseEntity> implements Dao<E> {
@Override
public List<E> findAll() {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
List<E> result = null;
try {

2
service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDaoImpl.java
View File

@ -38,7 +38,7 @@ public class SpellDaoImpl extends DaoBaseImpl<Spell> implements SpellDao {
@Override
public Spell findByName(String name) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
Spell result = null;
try {

2
service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDaoImpl.java
View File

@ -38,7 +38,7 @@ public class SpellbookDaoImpl extends DaoBaseImpl<Spellbook> implements Spellboo
@Override
public Spellbook findByName(String name) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
Spellbook result = null;
try {

2
service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDaoImpl.java
View File

@ -39,7 +39,7 @@ public class WizardDaoImpl extends DaoBaseImpl<Wizard> implements WizardDao {
@Override
public Wizard findByName(String name) {
Session session = getSession();
Session session = getSessionFactory().openSession();
Transaction tx = null;
Wizard result = null;
try {