Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations.

This commit is contained in:
Ilkka Seppala
2015-12-25 23:49:28 +02:00
parent 9fbb085985
commit cec9a99410
167 changed files with 1242 additions and 969 deletions

View File

@@ -14,7 +14,8 @@ public class AddressFilter extends AbstractFilter {
String result = super.execute(order);
if (order.getAddress() == null || order.getAddress().isEmpty()) {
return result + "Invalid address! ";
} else
} else {
return result;
}
}
}

View File

@@ -32,8 +32,12 @@ public class Client extends JFrame {
private JLabel jl;
private JTextField[] jtFields;
private JTextArea[] jtAreas;
private JButton clearButton, processButton;
private JButton clearButton;
private JButton processButton;
/**
* Constructor
*/
public Client() {
super("Client System");
setDefaultCloseOperation(EXIT_ON_CLOSE);

View File

@@ -11,30 +11,21 @@ public interface Filter {
/**
* Execute order processing filter.
*
* @param order
* @return empty string on success, otherwise error message.
*/
String execute(Order order);
/**
* Set next filter in chain after this.
*
* @param filter
*/
void setNext(Filter filter);
/**
* Get next filter in chain after this.
*
* @return
*/
Filter getNext();
/**
* Get last filter in the chain.
*
* @return
*/
Filter getLast();
}

View File

@@ -12,10 +12,16 @@ public class FilterChain {
private final Target target;
/**
* Constructor
*/
public FilterChain(Target target) {
this.target = target;
}
/**
* Adds filter
*/
public void addFilter(Filter filter) {
if (chain == null) {
chain = filter;
@@ -24,6 +30,9 @@ public class FilterChain {
}
}
/**
* Execute filter chain
*/
public String execute(Order order) {
if (chain != null) {
return chain.execute(order);

View File

@@ -14,6 +14,9 @@ public class Order {
public Order() {}
/**
* Constructor
*/
public Order(String name, String contactNumber, String address, String depositNumber, String order) {
this.name = name;
this.contactNumber = contactNumber;

View File

@@ -29,6 +29,9 @@ public class Target extends JFrame {
private DefaultTableModel dtm;
private JButton del;
/**
* Constructor
*/
public Target() {
super("Order System");
setDefaultCloseOperation(EXIT_ON_CLOSE);
@@ -67,8 +70,9 @@ public class Target extends JFrame {
@Override
public void actionPerformed(ActionEvent e) {
int temp = jt.getSelectedRow();
if (temp == -1)
if (temp == -1) {
return;
}
int temp2 = jt.getSelectedRowCount();
for (int i = 0; i < temp2; i++) {
dtm.removeRow(temp);

View File

@@ -73,6 +73,9 @@ public class FilterTest {
private final Order order;
private final String result;
/**
* Constructor
*/
public FilterTest(Filter filter, Order order, String result) {
this.filter = filter;
this.order = order;