Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations.

This commit is contained in:
Ilkka Seppala
2015-12-25 23:49:28 +02:00
parent 9fbb085985
commit cec9a99410
167 changed files with 1242 additions and 969 deletions
abstract-factory/src/main/java/com/iluwatar/abstractfactory
async-method-invocation/src
main
java
com
test
java
com
iluwatar
async
builder/src/main/java/com/iluwatar/builder
business-delegate/src/main/java/com/iluwatar/business/delegate
caching/src
callback/src/main/java/com/iluwatar/callback
chain/src/main/java/com/iluwatar/chain
checkstyle.xml
command/src/main/java/com/iluwatar/command
composite/src/main/java/com/iluwatar/composite
dao/src/main
java
com
resources
double-checked-locking/src
main
java
com
iluwatar
doublechecked
test
java
com
iluwatar
doublechecked
double-dispatch/src
main
java
com
iluwatar
test
java
com
iluwatar
doubledispatch
event-aggregator/src/test/java/com/iluwatar/event/aggregator
execute-around/src
main
java
com
iluwatar
test
java
com
iluwatar
facade/src/main/java/com/iluwatar/facade
fluentinterface/src
main
java
com
iluwatar
fluentinterface
test
java
com
iluwatar
fluentinterface
flux/src/main/java/com/iluwatar/flux/dispatcher
flyweight/src/main/java/com/iluwatar/flyweight
front-controller/src
half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync
intercepting-filter/src
main
test
java
com
iluwatar
intercepting
interpreter/src
main
java
com
iluwatar
interpreter
test
java
com
iluwatar
iterator/src
main
test
java
com
iluwatar
layers/src/main
lazy-loading/src/main/java/com/iluwatar/lazy/loading
memento/src/main/java/com/iluwatar/memento
message-channel/src/main/java/com/iluwatar/message/channel
model-view-presenter/src
main
test
java
com
iluwatar
monostate/src/main/java/com/iluwatar/monostate
naked-objects
dom
src
main
java
domainapp
dom
fixture
src
main
java
domainapp
integtests
webapp
src
main
java
domainapp
null-object/src/main/java/com/iluwatar/nullobject
object-pool/src/main/java/com/iluwatar/object/pool
observer/src/main/java/com/iluwatar/observer
poison-pill/src/main/java/com/iluwatar/poison/pill
pom.xml
private-class-data/src/main/java/com/iluwatar/privateclassdata
producer-consumer/src/main/java/com/iluwatar/producer/consumer
property/src/main/java/com/iluwatar/property
prototype/src/main/java/com/iluwatar/prototype
proxy/src/main/java/com/iluwatar/proxy
publish-subscribe/src/main/java/com/iluwatar/publish/subscribe
reactor/src/main/java/com/iluwatar/reactor
repository/src
resource-acquisition-is-initialization/src/main/java/com/iluwatar/resource/acquisition/is/initialization
servant/src/main/java/com/iluwatar/servant
service-layer/src/main/java/com/iluwatar/servicelayer
service-locator/src/main/java/com/iluwatar/servicelocator
singleton/src
specification/src/main/java/com/iluwatar/specification
state/src/main/java/com/iluwatar/state
step-builder/src/main/java/com/iluwatar/stepbuilder
template-method/src/main/java/com/iluwatar/templatemethod
tolerant-reader/src/main/java/com/iluwatar/tolerantreader
twin/src/main/java/com/iluwatar/twin
visitor/src/main/java/com/iluwatar/visitor

@@ -45,8 +45,6 @@ public class SimpleObjectCreate extends FixtureScript {
/**
* The created simple object (output).
*
* @return
*/
public SimpleObject getSimpleObject() {
return simpleObject;

@@ -29,7 +29,7 @@ import domainapp.fixture.modules.simple.SimpleObjectsTearDown;
public class RecreateSimpleObjects extends FixtureScript {
public final List<String> NAMES = Collections.unmodifiableList(Arrays.asList("Foo", "Bar", "Baz",
public final List<String> names = Collections.unmodifiableList(Arrays.asList("Foo", "Bar", "Baz",
"Frodo", "Froyo", "Fizz", "Bip", "Bop", "Bang", "Boo"));
public RecreateSimpleObjects() {
@@ -72,9 +72,9 @@ public class RecreateSimpleObjects extends FixtureScript {
final int number = defaultParam("number", ec, 3);
// validate
if (number < 0 || number > NAMES.size()) {
if (number < 0 || number > names.size()) {
throw new IllegalArgumentException(String.format("number must be in range [0,%d)",
NAMES.size()));
names.size()));
}
//
@@ -83,7 +83,7 @@ public class RecreateSimpleObjects extends FixtureScript {
ec.executeChild(this, new SimpleObjectsTearDown());
for (int i = 0; i < number; i++) {
final SimpleObjectCreate fs = new SimpleObjectCreate().setName(NAMES.get(i));
final SimpleObjectCreate fs = new SimpleObjectCreate().setName(names.get(i));
ec.executeChild(this, fs.getName(), fs);
simpleObjects.add(fs.getSimpleObject());
}