From 4e40cc38886cb9bec78cdd3d4e25592d547dfc12 Mon Sep 17 00:00:00 2001
From: Mohammed Ezzat <mohamed.ezzat@aurea.com>
Date: Wed, 27 Jan 2016 02:45:39 +0200
Subject: [PATCH] squid:S1488 - Local Variables should not be declared and then
 immediately returned or thrown

---
 caching/src/main/java/com/iluwatar/caching/DbManager.java   | 4 +---
 dao/src/main/java/com/iluwatar/dao/Customer.java            | 3 +--
 .../fluentiterable/lazy/LazyFluentIterable.java             | 3 +--
 .../src/main/java/domainapp/webapp/SimpleApplication.java   | 6 ++----
 4 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/caching/src/main/java/com/iluwatar/caching/DbManager.java b/caching/src/main/java/com/iluwatar/caching/DbManager.java
index bfde07103..5b2a1db25 100644
--- a/caching/src/main/java/com/iluwatar/caching/DbManager.java
+++ b/caching/src/main/java/com/iluwatar/caching/DbManager.java
@@ -72,9 +72,7 @@ public class DbManager {
       return null;
     }
     Document doc = iterable.first();
-    UserAccount userAccount =
-        new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));
-    return userAccount;
+    return new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));
   }
 
   /**
diff --git a/dao/src/main/java/com/iluwatar/dao/Customer.java b/dao/src/main/java/com/iluwatar/dao/Customer.java
index ea13daf11..9abc233b0 100644
--- a/dao/src/main/java/com/iluwatar/dao/Customer.java
+++ b/dao/src/main/java/com/iluwatar/dao/Customer.java
@@ -66,7 +66,6 @@ public class Customer {
 
   @Override
   public int hashCode() {
-    int result = getId();
-    return result;
+    return getId();
   }
 }
diff --git a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java
index e887ad556..e72d1672a 100644
--- a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java
+++ b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java
@@ -204,8 +204,7 @@ public class LazyFluentIterable<TYPE> implements FluentIterable<TYPE> {
    */
   @Override
   public List<TYPE> asList() {
-    List<TYPE> copy = FluentIterable.copyToList(iterable);
-    return copy;
+    return FluentIterable.copyToList(iterable);
   }
 
   @Override
diff --git a/naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java b/naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java
index a292a7779..89d316d20 100644
--- a/naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java
+++ b/naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java
@@ -118,8 +118,7 @@ public class SimpleApplication extends IsisWicketApplication {
     } catch (Exception e) {
       System.out.println(e);
     }
-    WebRequest request = super.newWebRequest(servletRequest, filterPath);
-    return request;
+    return super.newWebRequest(servletRequest, filterPath);
   }
 
   @Override
@@ -150,8 +149,7 @@ public class SimpleApplication extends IsisWicketApplication {
       List<String> readLines =
           Resources.readLines(Resources.getResource(contextClass, resourceName),
               Charset.defaultCharset());
-      final String aboutText = Joiner.on("\n").join(readLines);
-      return aboutText;
+      return Joiner.on("\n").join(readLines);
     } catch (IOException e) {
       return "This is a simple app";
     }