From df4a40fc1338c9bc7ecc7cde6343c832423228df Mon Sep 17 00:00:00 2001
From: Mohammed Ezzat <mohamed.ezzat@aurea.com>
Date: Wed, 3 Feb 2016 17:40:02 +0200
Subject: [PATCH] squid:S1186 - Methods should not be empty

---
 .../src/main/java/com/iluwatar/nullobject/NullNode.java   | 4 +++-
 .../main/java/com/iluwatar/visitor/CommanderVisitor.java  | 8 ++++++--
 .../main/java/com/iluwatar/visitor/SergeantVisitor.java   | 8 ++++++--
 .../main/java/com/iluwatar/visitor/SoldierVisitor.java    | 8 ++++++--
 4 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java b/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java
index 485b1bd5d..26e3db4f1 100644
--- a/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java
+++ b/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java
@@ -60,5 +60,7 @@ public class NullNode implements Node {
   }
 
   @Override
-  public void walk() {}
+  public void walk() {
+    // Do nothing
+  }
 }
diff --git a/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java
index b0b9d5708..6e54c7861 100644
--- a/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java
+++ b/visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java
@@ -30,10 +30,14 @@ package com.iluwatar.visitor;
 public class CommanderVisitor implements UnitVisitor {
 
   @Override
-  public void visitSoldier(Soldier soldier) {}
+  public void visitSoldier(Soldier soldier) {
+    // Do nothing
+  }
 
   @Override
-  public void visitSergeant(Sergeant sergeant) {}
+  public void visitSergeant(Sergeant sergeant) {
+    // Do nothing
+  }
 
   @Override
   public void visitCommander(Commander commander) {
diff --git a/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java
index dbaa93034..4fca0a5bd 100644
--- a/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java
+++ b/visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java
@@ -30,7 +30,9 @@ package com.iluwatar.visitor;
 public class SergeantVisitor implements UnitVisitor {
 
   @Override
-  public void visitSoldier(Soldier soldier) {}
+  public void visitSoldier(Soldier soldier) {
+    // Do nothing
+  }
 
   @Override
   public void visitSergeant(Sergeant sergeant) {
@@ -38,5 +40,7 @@ public class SergeantVisitor implements UnitVisitor {
   }
 
   @Override
-  public void visitCommander(Commander commander) {}
+  public void visitCommander(Commander commander) {
+    // Do nothing
+  }
 }
diff --git a/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java b/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java
index a2abbb9e5..fff24f699 100644
--- a/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java
+++ b/visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java
@@ -35,8 +35,12 @@ public class SoldierVisitor implements UnitVisitor {
   }
 
   @Override
-  public void visitSergeant(Sergeant sergeant) {}
+  public void visitSergeant(Sergeant sergeant) {
+    // Do nothing
+  }
 
   @Override
-  public void visitCommander(Commander commander) {}
+  public void visitCommander(Commander commander) {
+    // Do nothing
+  }
 }