From 0003c6cb0034f3967c7a85d5dab1f920d0e9d02e Mon Sep 17 00:00:00 2001 From: Mohammed Ezzat Date: Thu, 18 Feb 2016 08:40:19 +0200 Subject: [PATCH] pmd:RedundantFieldInitializer - Redundant-Field-Initializer --- caching/src/main/java/com/iluwatar/caching/CacheStore.java | 2 +- caching/src/main/java/com/iluwatar/caching/LruCache.java | 4 ++-- chain/src/main/java/com/iluwatar/chain/Request.java | 2 +- .../fluentiterable/lazy/DecoratingIterator.java | 2 +- .../fluentiterable/lazy/LazyFluentIterable.java | 4 ++-- .../java/com/iluwatar/model/view/presenter/FileLoader.java | 2 +- .../src/main/java/com/iluwatar/monostate/LoadBalancer.java | 4 ++-- .../main/java/com/iluwatar/producer/consumer/Producer.java | 2 +- .../com/iluwatar/reader/writer/lock/ReaderWriterLock.java | 2 +- .../src/main/java/com/iluwatar/reader/writer/lock/Writer.java | 2 +- .../iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java | 2 +- twin/src/main/java/com/iluwatar/twin/BallItem.java | 2 +- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/caching/src/main/java/com/iluwatar/caching/CacheStore.java b/caching/src/main/java/com/iluwatar/caching/CacheStore.java index db8f3bed7..e2e04076a 100644 --- a/caching/src/main/java/com/iluwatar/caching/CacheStore.java +++ b/caching/src/main/java/com/iluwatar/caching/CacheStore.java @@ -31,7 +31,7 @@ import java.util.ArrayList; */ public class CacheStore { - static LruCache cache = null; + static LruCache cache; private CacheStore() { } diff --git a/caching/src/main/java/com/iluwatar/caching/LruCache.java b/caching/src/main/java/com/iluwatar/caching/LruCache.java index 6c86c1a53..c5e1a9d46 100644 --- a/caching/src/main/java/com/iluwatar/caching/LruCache.java +++ b/caching/src/main/java/com/iluwatar/caching/LruCache.java @@ -50,8 +50,8 @@ public class LruCache { int capacity; HashMap cache = new HashMap<>(); - Node head = null; - Node end = null; + Node head; + Node end; public LruCache(int capacity) { this.capacity = capacity; diff --git a/chain/src/main/java/com/iluwatar/chain/Request.java b/chain/src/main/java/com/iluwatar/chain/Request.java index f6a15ff5a..399eddb36 100644 --- a/chain/src/main/java/com/iluwatar/chain/Request.java +++ b/chain/src/main/java/com/iluwatar/chain/Request.java @@ -44,7 +44,7 @@ public class Request { * Indicates if the request is handled or not. A request can only switch state from unhandled to * handled, there's no way to 'unhandle' a request */ - private boolean handled = false; + private boolean handled; /** * Create a new request of the given type and accompanied description. diff --git a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/DecoratingIterator.java b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/DecoratingIterator.java index c8b7520ac..d15cecea7 100644 --- a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/DecoratingIterator.java +++ b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/DecoratingIterator.java @@ -32,7 +32,7 @@ public abstract class DecoratingIterator implements Iterator { protected final Iterator fromIterator; - private TYPE next = null; + private TYPE next; /** * Creates an iterator that decorates the given iterator. diff --git a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java index bf4403685..8b7f88101 100644 --- a/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java +++ b/fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java @@ -111,7 +111,7 @@ public class LazyFluentIterable implements FluentIterable { @Override public Iterator iterator() { return new DecoratingIterator(iterable.iterator()) { - int currentIndex = 0; + int currentIndex; @Override public TYPE computeNext() { @@ -156,7 +156,7 @@ public class LazyFluentIterable implements FluentIterable { private int stopIndex; private int totalElementsCount; private List list; - private int currentIndex = 0; + private int currentIndex; @Override public TYPE computeNext() { diff --git a/model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileLoader.java b/model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileLoader.java index 2b9b26d96..b9e36fd00 100644 --- a/model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileLoader.java +++ b/model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileLoader.java @@ -37,7 +37,7 @@ public class FileLoader { /** * Indicates if the file is loaded or not. */ - private boolean loaded = false; + private boolean loaded; /** * The name of the file that we want to load. diff --git a/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java b/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java index b0d0f283c..613f0e105 100644 --- a/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java +++ b/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java @@ -35,8 +35,8 @@ import java.util.List; public class LoadBalancer { private static List servers = new ArrayList<>(); - private static int id = 0; - private static int lastServedId = 0; + private static int id; + private static int lastServedId; static { servers.add(new Server("localhost", 8081, ++id)); diff --git a/producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java b/producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java index 8d21c0816..587614dc8 100644 --- a/producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java +++ b/producer-consumer/src/main/java/com/iluwatar/producer/consumer/Producer.java @@ -34,7 +34,7 @@ public class Producer { private final String name; - private int itemId = 0; + private int itemId; public Producer(String name, ItemQueue queue) { this.name = name; diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java index 32760d5b4..c8f59edd5 100644 --- a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java +++ b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java @@ -40,7 +40,7 @@ public class ReaderWriterLock implements ReadWriteLock { private Object readerMutex = new Object(); - private int currentReaderCount = 0; + private int currentReaderCount; /** * Global mutex is used to indicate that whether reader or writer gets the lock in the moment. diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java index ecb54f330..fc3c3bb88 100644 --- a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java +++ b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java @@ -29,7 +29,7 @@ import java.util.concurrent.locks.Lock; */ public class Writer implements Runnable { - private Lock writeLock = null; + private Lock writeLock; private String name; diff --git a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java b/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java index ac4c39f2c..236fb4da4 100644 --- a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java +++ b/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java @@ -31,7 +31,7 @@ package com.iluwatar.singleton; */ public class ThreadSafeLazyLoadedIvoryTower { - private static ThreadSafeLazyLoadedIvoryTower instance = null; + private static ThreadSafeLazyLoadedIvoryTower instance; private ThreadSafeLazyLoadedIvoryTower() {} diff --git a/twin/src/main/java/com/iluwatar/twin/BallItem.java b/twin/src/main/java/com/iluwatar/twin/BallItem.java index 4e6ecc15e..0188b5731 100644 --- a/twin/src/main/java/com/iluwatar/twin/BallItem.java +++ b/twin/src/main/java/com/iluwatar/twin/BallItem.java @@ -30,7 +30,7 @@ package com.iluwatar.twin; */ public class BallItem extends GameItem { - private boolean isSuspended = false; + private boolean isSuspended; private BallThread twin;