gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #365 from DevFactory/release/Append-Character-With-Char-fix-1

Browse Source 
pmd:AppendCharacterWithChar - Append Character With Char
This commit is contained in:
Ilkka Seppälä
2016-02-01 22:28:34 +02:00
parent f08af14555 7adefc89ba
commit e05592b522
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
builder/src/main/java/com/iluwatar/builder/Hero.java
View File

@@ -71,10 +71,10 @@ public class Hero {
if (hairColor != null || hairType != null) { if (hairColor != null || hairType != null) {
sb.append(" with "); sb.append(" with ");
if (hairColor != null) { if (hairColor != null) {
sb.append(hairColor).append(" "); sb.append(hairColor).append(' ');
} }
if (hairType != null) { if (hairType != null) {
sb.append(hairType).append(" "); sb.append(hairType).append(' ');
} }
sb.append(hairType != HairType.BALD ? "hair" : "head"); sb.append(hairType != HairType.BALD ? "hair" : "head");
} }
@@ -84,7 +84,7 @@ public class Hero {
if (weapon != null) { if (weapon != null) {
sb.append(" and wielding a ").append(weapon); sb.append(" and wielding a ").append(weapon);
} }
sb.append("."); sb.append('.');
return sb.toString(); return sb.toString();
} }

6
property/src/main/java/com/iluwatar/property/Character.java
View File

@@ -114,11 +114,11 @@ public class Character implements Prototype {
public String toString() { public String toString() {
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
if (name != null) { if (name != null) {
builder.append("Player: ").append(name).append("\n"); builder.append("Player: ").append(name).append('\n');
} }
if (type != null) { if (type != null) {
builder.append("Character type: ").append(type.name()).append("\n"); builder.append("Character type: ").append(type.name()).append('\n');
} }
builder.append("Stats:\n"); builder.append("Stats:\n");
@@ -127,7 +127,7 @@ public class Character implements Prototype {
if (value == null) { if (value == null) {
continue; continue;
} }
builder.append(" - ").append(stat.name()).append(":").append(value).append("\n"); builder.append(" - ").append(stat.name()).append(':').append(value).append('\n');
} }
return builder.toString(); return builder.toString();
} }

2
step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java
View File

@@ -98,7 +98,7 @@ public class Character {
.append(" armed with a ") .append(" armed with a ")
.append(weapon != null ? weapon : spell != null ? spell : "with nothing") .append(weapon != null ? weapon : spell != null ? spell : "with nothing")
.append(abilities != null ? (" and wielding " + abilities + " abilities") : "") .append(abilities != null ? (" and wielding " + abilities + " abilities") : "")
.append("."); .append('.');
return sb.toString(); return sb.toString();
} }
} }