gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix Sonar critical issue - fix code smells

Browse Source
This commit is contained in:
atayal
2021-10-31 21:16:27 +05:30
parent 2495aedbb0
commit e2054ceaa3
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
commander/src/main/java/com/iluwatar/commander/Commander.java
View File

@ -134,8 +134,8 @@ public class Commander {
} }
String transactionId = shippingService.receiveRequest(order.item, order.user.address); String transactionId = shippingService.receiveRequest(order.item, order.user.address);
//could save this transaction id in a db too //could save this transaction id in a db too
LOG.info(ORDER_ID + ": Shipping placed successfully, transaction id: " LOG.info(ORDER_ID + ": Shipping placed successfully, transaction id: {}",
+ transactionId, order.id); order.id, transactionId);
LOG.info("Order has been placed and will be shipped to you. Please wait while we make your" LOG.info("Order has been placed and will be shipped to you. Please wait while we make your"
+ " payment... "); + " payment... ");
sendPaymentRequest(order); sendPaymentRequest(order);
@ -152,8 +152,8 @@ public class Commander {
LOG.info("This item is currently unavailable. We will inform you as soon as the item " LOG.info("This item is currently unavailable. We will inform you as soon as the item "
+ "becomes available again."); + "becomes available again.");
finalSiteMsgShown = true; finalSiteMsgShown = true;
LOG.info(ORDER_ID + ": Item " + order.item + " unavailable, trying to add " LOG.info(ORDER_ID + ": Item {}" + " unavailable, trying to add "
+ "problem to employee handle..", order.id); + "problem to employee handle..", order.id, order.item);
employeeHandleIssue(o); employeeHandleIssue(o);
} else { } else {
LOG.info("Sorry, there was a problem in creating your order. Please try later."); LOG.info("Sorry, there was a problem in creating your order. Please try later.");
@ -190,7 +190,8 @@ public class Commander {
if (order.paid.equals(PaymentStatus.TRYING)) { if (order.paid.equals(PaymentStatus.TRYING)) {
var transactionId = paymentService.receiveRequest(order.price); var transactionId = paymentService.receiveRequest(order.price);
order.paid = PaymentStatus.DONE; order.paid = PaymentStatus.DONE;
LOG.info(ORDER_ID + ": Payment successful, transaction Id: " + transactionId, order.id); LOG.info(ORDER_ID + ": Payment successful, transaction Id: {}",
order.id, transactionId);
if (!finalSiteMsgShown) { if (!finalSiteMsgShown) {
LOG.info("Payment made successfully, thank you for shopping with us!!"); LOG.info("Payment made successfully, thank you for shopping with us!!");
finalSiteMsgShown = true; finalSiteMsgShown = true;
@ -271,8 +272,8 @@ public class Commander {
LOG.error(ORDER_ID + ": Unable to enqueue payment task," LOG.error(ORDER_ID + ": Unable to enqueue payment task,"
+ " payment failed..", qt1.order.id); + " payment failed..", qt1.order.id);
} }
LOG.error(ORDER_ID + ": Unable to enqueue task of type " + qt1.getType() LOG.error(ORDER_ID + ": Unable to enqueue task of type {}"
+ ", trying to add to employee handle..", qt1.order.id); + ", trying to add to employee handle..", qt1.order.id, qt1.getType());
employeeHandleIssue(qt1.order); employeeHandleIssue(qt1.order);
}; };
var r = new Retry<>(op, handleError, numOfRetries, retryDuration, var r = new Retry<>(op, handleError, numOfRetries, retryDuration,