gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Java 11 migraiton: module

Browse Source
This commit is contained in:
Anurag Agarwal
2020-04-12 22:38:00 +00:00
parent 99c70af16a
commit f1b27ef5c7
4 changed files with 59 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
module/pom.xml
View File

@ -23,7 +23,8 @@
THE SOFTWARE.
-->
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.iluwatar</groupId>

6
module/src/main/java/com/iluwatar/module/App.java
View File

@ -65,10 +65,8 @@ public class App {
/**
* Following method is main executor.
*
* @param args for providing default program arguments
*/
public static void execute(final String... args) {
public static void execute() {
/* Send logs on file system */
fileLoggerModule.printString("Message");
@ -88,7 +86,7 @@ public class App {
*/
public static void main(final String... args) throws FileNotFoundException {
prepare();
execute(args);
execute();
unprepare();
}
}

6
module/src/test/java/com/iluwatar/module/AppTest.java
View File

@ -23,9 +23,8 @@
package com.iluwatar.module;
import org.junit.jupiter.api.Test;
import java.io.FileNotFoundException;
import org.junit.jupiter.api.Test;
/**
* Tests that Module example runs without errors.
@ -34,7 +33,6 @@ public final class AppTest {
@Test
public void test() throws FileNotFoundException {
final String[] args = {};
App.main(args);
App.main();
}
}

27
module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java
View File

@ -23,17 +23,16 @@
package com.iluwatar.module;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* The Module pattern can be considered a Creational pattern and a Structural pattern. It manages
@ -65,7 +64,7 @@ public final class FileLoggerModuleTest {
public void testFileMessage() throws IOException {
/* Get singletong instance of File Logger Module */
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
final var fileLoggerModule = FileLoggerModule.getSingleton();
/* Prepare the essential sub modules, to perform the sequence of jobs */
fileLoggerModule.prepare();
@ -88,8 +87,8 @@ public final class FileLoggerModuleTest {
@Test
public void testNoFileMessage() throws IOException {
/* Get singletong instance of File Logger Module */
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
/* Get singleton instance of File Logger Module */
final var fileLoggerModule = FileLoggerModule.getSingleton();
/* Prepare the essential sub modules, to perform the sequence of jobs */
fileLoggerModule.prepare();
@ -111,7 +110,7 @@ public final class FileLoggerModuleTest {
public void testFileErrorMessage() throws FileNotFoundException {
/* Get singletong instance of File Logger Module */
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
final var fileLoggerModule = FileLoggerModule.getSingleton();
/* Prepare the essential sub modules, to perform the sequence of jobs */
fileLoggerModule.prepare();
@ -122,7 +121,7 @@ public final class FileLoggerModuleTest {
/* Test if 'Message' is printed in file */
assertEquals(ERROR, readFirstLine(ERROR_FILE));
/* Unprepare to cleanup the modules */
/* Un-prepare to cleanup the modules */
fileLoggerModule.unprepare();
}
@ -136,7 +135,7 @@ public final class FileLoggerModuleTest {
public void testNoFileErrorMessage() throws FileNotFoundException {
/* Get singletong instance of File Logger Module */
final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
final var fileLoggerModule = FileLoggerModule.getSingleton();
/* Prepare the essential sub modules, to perform the sequence of jobs */
fileLoggerModule.prepare();
@ -154,10 +153,10 @@ public final class FileLoggerModuleTest {
* @param file as file name to be read
* @return a string value as first line in file
*/
private static final String readFirstLine(final String file) {
private static String readFirstLine(final String file) {
String firstLine = null;
try (BufferedReader bufferedReader = new BufferedReader(new FileReader(file))) {
try (var bufferedReader = new BufferedReader(new FileReader(file))) {
while (bufferedReader.ready()) {