Resolves checkstyle errors for delegation dependency-injection dirty-flag double-buffer double-checked-locking double-dispatch (#1068)
* Reduces checkstyle errors in delegation * Reduces checkstyle errors in dependency-injection * Reduces checkstyle errors in dirty-flag * Reduces checkstyle errors in double-buffer * Reduces checkstyle errors in double-checked-locking * Reduces checkstyle errors in double-dispatch
This commit is contained in:
committed by
Ilkka Seppälä
parent
01e489c77b
commit
f2c91eb836
@@ -23,30 +23,6 @@
|
||||
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
* The MIT License
|
||||
* Copyright (c) 2014-2017 Ilkka Seppälä
|
||||
* <p>
|
||||
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
* of this software and associated documentation files (the "Software"), to deal
|
||||
* in the Software without restriction, including without limitation the rights
|
||||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
* copies of the Software, and to permit persons to whom the Software is
|
||||
* furnished to do so, subject to the following conditions:
|
||||
* <p>
|
||||
* The above copyright notice and this permission notice shall be included in
|
||||
* all copies or substantial portions of the Software.
|
||||
* <p>
|
||||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
* THE SOFTWARE.
|
||||
*/
|
||||
|
||||
|
||||
/**
|
||||
* AdvancedSorceress implements inversion of control. It depends on abstraction that can be injected
|
||||
* through its setter.
|
||||
|
@@ -24,10 +24,8 @@
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
*
|
||||
* AdvancedWizard implements inversion of control. It depends on abstraction that can be injected
|
||||
* through its constructor.
|
||||
*
|
||||
*/
|
||||
public class AdvancedWizard implements Wizard {
|
||||
|
||||
|
@@ -31,25 +31,26 @@ import com.google.inject.Injector;
|
||||
* implements so called inversion of control principle. Inversion of control has two specific rules:
|
||||
* - High-level modules should not depend on low-level modules. Both should depend on abstractions.
|
||||
* - Abstractions should not depend on details. Details should depend on abstractions.
|
||||
* <p>
|
||||
* In this example we show you three different wizards. The first one ({@link SimpleWizard}) is a
|
||||
* naive implementation violating the inversion of control principle. It depends directly on a
|
||||
*
|
||||
* <p>In this example we show you three different wizards. The first one ({@link SimpleWizard}) is
|
||||
* a naive implementation violating the inversion of control principle. It depends directly on a
|
||||
* concrete implementation which cannot be changed.
|
||||
* <p>
|
||||
* The second and third wizards({@link AdvancedWizard} and {@link AdvancedSorceress}) are more flexible.
|
||||
* They do not depend on any concrete implementation but abstraction. They utilizes Dependency Injection
|
||||
* pattern allowing their {@link Tobacco} dependency to be injected through constructor ({@link AdvancedWizard})
|
||||
* or setter ({@link AdvancedSorceress}). This way, handling the dependency is no longer the wizard's
|
||||
* responsibility. It is resolved outside the wizard class.
|
||||
* <p>
|
||||
* The fourth example takes the pattern a step further. It uses Guice framework for Dependency
|
||||
*
|
||||
* <p>The second and third wizards({@link AdvancedWizard} and {@link AdvancedSorceress}) are more
|
||||
* flexible. They do not depend on any concrete implementation but abstraction. They utilizes
|
||||
* Dependency Injection pattern allowing their {@link Tobacco} dependency to be injected through
|
||||
* constructor ({@link AdvancedWizard}) or setter ({@link AdvancedSorceress}). This way, handling
|
||||
* the dependency is no longer the wizard's responsibility. It is resolved outside the wizard
|
||||
* class.
|
||||
*
|
||||
* <p>The fourth example takes the pattern a step further. It uses Guice framework for Dependency
|
||||
* Injection. {@link TobaccoModule} binds a concrete implementation to abstraction. Injector is then
|
||||
* used to create {@link GuiceWizard} object with correct dependencies.
|
||||
*/
|
||||
public class App {
|
||||
|
||||
/**
|
||||
* Program entry point
|
||||
* Program entry point.
|
||||
*
|
||||
* @param args command line args
|
||||
*/
|
||||
|
@@ -26,10 +26,8 @@ package com.iluwatar.dependency.injection;
|
||||
import javax.inject.Inject;
|
||||
|
||||
/**
|
||||
*
|
||||
* GuiceWizard implements inversion of control. Its dependencies are injected through its
|
||||
* constructor by Guice framework.
|
||||
*
|
||||
*/
|
||||
public class GuiceWizard implements Wizard {
|
||||
|
||||
|
@@ -24,9 +24,7 @@
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
*
|
||||
* OldTobyTobacco concrete {@link Tobacco} implementation
|
||||
*
|
||||
* OldTobyTobacco concrete {@link Tobacco} implementation.
|
||||
*/
|
||||
public class OldTobyTobacco extends Tobacco {
|
||||
}
|
||||
|
@@ -24,9 +24,7 @@
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
*
|
||||
* RivendellTobacco concrete {@link Tobacco} implementation
|
||||
*
|
||||
* RivendellTobacco concrete {@link Tobacco} implementation.
|
||||
*/
|
||||
public class RivendellTobacco extends Tobacco {
|
||||
}
|
||||
|
@@ -24,9 +24,7 @@
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
*
|
||||
* SecondBreakfastTobacco concrete {@link Tobacco} implementation
|
||||
*
|
||||
* SecondBreakfastTobacco concrete {@link Tobacco} implementation.
|
||||
*/
|
||||
public class SecondBreakfastTobacco extends Tobacco {
|
||||
}
|
||||
|
@@ -24,10 +24,8 @@
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
*
|
||||
* Naive Wizard implementation violating the inversion of control principle. It should depend on
|
||||
* abstraction instead.
|
||||
*
|
||||
*/
|
||||
public class SimpleWizard implements Wizard {
|
||||
|
||||
|
@@ -27,9 +27,7 @@ import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
/**
|
||||
*
|
||||
* Tobacco abstraction
|
||||
*
|
||||
* Tobacco abstraction.
|
||||
*/
|
||||
public abstract class Tobacco {
|
||||
|
||||
|
@@ -26,9 +26,7 @@ package com.iluwatar.dependency.injection;
|
||||
import com.google.inject.AbstractModule;
|
||||
|
||||
/**
|
||||
*
|
||||
* Guice module for binding certain concrete {@link Tobacco} implementation.
|
||||
*
|
||||
*/
|
||||
public class TobaccoModule extends AbstractModule {
|
||||
|
||||
|
@@ -24,9 +24,7 @@
|
||||
package com.iluwatar.dependency.injection;
|
||||
|
||||
/**
|
||||
*
|
||||
* Wizard interface
|
||||
*
|
||||
* Wizard interface.
|
||||
*/
|
||||
public interface Wizard {
|
||||
|
||||
|
Reference in New Issue
Block a user