gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3,150 Commits 254 Branches 19 Tags
Commit Graph

83 Commits

Author SHA1 Message Date
va1m
5cf2fe009b
📍Use lombok, reformat, and optimize the code (#1560) 
* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>
 2021-03-13 14:19:21 +02:00
Subhrodip Mohanta
b423002e6c
updated Random() to SecureRandom() (#1670) 
* updated Random() to SecureRandom()

* batch 2 of SecureRandom updates
 2021-03-06 13:26:02 +02:00
Subhrodip Mohanta
7891c2b117
update inception year to 2021 (#1653) 2021-02-14 11:57:57 +02:00
Toxic Dreamz
31471acb69 Fixed most reported issues by SonarCloud. 2020-08-15 21:47:39 +04:00
Ilkka Seppälä
417f21ed3d
Code cleanup (#1461) 
* Code cleanup

* Fix flux tests

* Fix checkstyle errors

* Fix compile error
 2020-07-30 20:28:47 +03:00
Anurag Agarwal
f835d3d516 Java 11 migrate remaining (g,h,i) (#1116) 
* Moves game-loop to Java 11

* Moves guarded-suspension to Java 11

* Moves half-sync-half-async to Java 11

* Moves hexagonal to Java 11

* Moves intercepting-filter to Java 11

* Moves interpreter to Java 11

* Moves iterator to Java 11
 2019-12-20 07:11:30 +02:00
Anurag Agarwal
dda09535e6 Resolves checkstyle errors for guarded-suspension, half-sync-half-async, hexagonal (#1064) 
* Reduces checkstyle errors in guarded-suspension

* Reduces checkstyle errors in half-sync-half-async

* Reduces checkstyle errors in hexagonal
 2019-11-10 19:01:32 +02:00
Leon Mak
c8a481bb77 Add java 11 support for #987 (o-t) (#1051) 
* Use java 11

* Use .of
- Replace Arrays.asList with List.of
- Replace HashSet<>(List.of()) with Set.of

* Formatting
 2019-10-29 08:37:40 +02:00
Leon Mak
dd971d8c19 Use java 11 (#1050) 2019-10-28 17:02:17 +02:00
Alexander Ivanov
4904d7eea0 #1021: Fix checkstyle warnings by changing the license header template (#1027) 
* Add custom license header style in order to comply with Google's Checkstyle format

* Update license headers to comply with Google's Checkstyle format
 2019-10-22 08:15:35 +03:00
Christopher O'Connell
82f9a6c232 1010: Fixed the two remaining SonarCloud errors (#1023) 
The two remaining files were still creating a Random everytime the method
was called. These were missed in the previous commit because the previous
commit had fixed only one of the methods; in other words, there were
multiple methods that were creating the Random object on each call.
 2019-10-20 09:02:36 +03:00
Christopher O'Connell
7c5d5f6b0d 1010: Fixed all of the blocking and critical Sonarcloud errors (#1020) 
* 1011: Added SuppressWarnings for SonarCloud errors

All of these files are causing SonarCloud to report the following error:

Loops should not be infinite

Since these instances all require an infinite loop that will never end,
these warnings should be disabled so that SonarCloud no longer reports
them as error.

The rule is: squid:S2189

* 1011: Made all of the randoms static and final

According to SonarCloud rule: "Random" objects should be reused, randoms
should not be recreated. This commit has taken all of the Randoms and made
them constant variables in the files that are using them.
 2019-10-19 20:04:44 +03:00
Joshua Jimenez
cfdfedbd2e #970 single logging framework should be enforced (#982) 
* #496 Add pipeline module to parent pom ✨

* #496: Add main application class and test for pipeline

* #496: Checkstyle format and add log messages on pipeline stages 🎨

* #496: Fill readme sections of pipeline ✨

* #496: Javadocs and checkstyle formatting 🎨

* #496: Follow PMD checks and add more explanation as block comment on App.java

* #496: Apply requested PR changes by iluwatar 🎨

* #970: Replace log4j usage on commander pattern to Slf4j API 🎨

* #970: Replace log4j usage on dao pattern to Slf4j API 🎨

* #970: Replace log4j usage on data mapper pattern to Slf4j API 🎨

* #970: Remove log4j dependency on data transfer object pom 🔥

* #970: Replace log4j usage on module pattern to Slf4j API 🎨

* #970: Replace log4j usage on serverless pattern to Slf4j API 🎨

This also removes the aws log4j dependency

* #970: Remove unnecessary gitignore line for log4j.xml 🔥

* #970: Remove remaining remnants of log4j 🔥

* #970: Replace System.out logging with appropriate logging methods 🎨

* #970: Replace System.out method references to Logger::info 🎨
 2019-10-13 23:41:11 +03:00
Ilkka Seppälä
9ebbc421dd Update license headers 2019-10-12 20:05:54 +03:00
Per Wramdemark
218ba44dbf Upgrade of maven plugins (#951) 
* Upgrade maven plugins

* Upgrade maven plugins

Some general code cleanup was necessary due to upgrade of PMD and checkstyle.

Also needed to add Junit 4 as a dependency due to Mockito.timout issue found here:
https://github.com/mockito/mockito/issues/152
 2019-10-05 14:23:20 +03:00
Paweł Matejko
4446e74338 Hexagonal pattern fixes (#814) 
* Fixed wrong else condition

* Simplified creating Set of numbers

* Deleted unused imports

* Replaced 'for' loop with 'foreach' one

* Replaced explicit type with diamond

* Removed unnecesary brackets from lambda

* Removed unnecesary contains check before adding element to Set

* Fixed typo and changed non-english constant names
 2018-10-27 16:39:16 +05:30
Narendra Pathai
37ae182630 Resolved PMD issues 2018-10-15 13:30:20 +05:30
Narendra Pathai
ab2c12e734 1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5 2018-10-15 13:21:00 +05:30
Nick Andrievsky
1d12d94bac Fix redundant list alloc in LotteryNumbers 2018-09-11 11:55:53 +02:00
Ilkka Seppälä
16df157181 Add license headers 2018-08-13 08:13:06 +03:00
Agustí Becerra Milà
b453753790 Fix import not used 2018-07-08 19:38:54 +02:00
Agustí Becerra Milà
d2b900b524 Fix checkstyle & update interface services 2018-07-08 19:25:42 +02:00
Agustí Becerra Milà
ae07423470 First proposal 2018-07-01 16:29:07 +02:00
baislsl
991ba320a6 Improve Javadoc 2018-02-19 22:01:14 +08:00
Artur Mogozov
6694d742a3 Migrate to JUnit5 2017-12-31 16:29:48 +09:00
Mudit Porwal
09585c3874 Removed AvoidStarImport Rule 
Added JavaDocType Rule
 2017-03-22 01:16:02 +08:00
Ilkka Seppälä
9ec0935a1c Merge pull request #532 from leogtzr/master 
Adding initialization-on-demand idiom and noninstantiable class instead of interface constant idiom
 2017-01-23 08:21:07 +02:00
leogtzr
d6fc28e120 Changing code to use interfaces instead of implementations. 2017-01-21 15:47:54 -07:00
Krisztián Nagy
95f2c19780 Sonar bug fixes using Yoda condition in equals expression when comparing String literal with String object. 
Using try-with-resources if we use Scanner to close the underlying stream is a good practice to handle resources.
Minimal refactor.
 2016-12-18 16:08:59 +01:00
Krisztián Nagy
120033b58b Sonar bug fixes using Yoda condition in equals expression when comparing String literal with String object. 
Using try-with-resources if we use Scanner to close the underlying stream is a good practice to handle resources.
Minimal refactor.
 2016-12-18 16:04:13 +01:00
Ilkka Seppälä
faa29f8025 Update license headers 2016-11-27 14:34:20 +02:00
daniel-bryla
e138163c4f #502 Adjusted tests for logger introduction 2016-11-04 11:47:06 +01:00
daniel-bryla
0438811489 #502 Replaced usages of System.out with logger. 2016-10-23 19:59:03 +02:00
Ilkka Seppälä
b030cd4eba Hexagonal pattern: Introduce lottery utils class 2016-09-17 09:20:33 +03:00
Ilkka Seppälä
6aa58e8ae6 Hexagonal pattern: Remove unnecessary factories 2016-09-17 09:07:06 +03:00
Ilkka Seppälä
914d1353a1 Hexagonal pattern: Update test application description 2016-09-15 21:56:15 +03:00
Ilkka Seppälä
df32a7b893 Hexagonal pattern: Introduced lottery events port with two adapters 2016-09-15 21:45:09 +03:00
Ilkka Seppälä
c4c5e78e50 Hexagonal pattern: Improve error handling in console lottery 2016-09-14 22:18:42 +03:00
Ilkka Seppälä
3cf2b34d2a Hexagonal pattern: Improve connection properties handling 2016-09-14 22:01:41 +03:00
Ilkka Seppälä
27e8cb7f2d Hexagonal pattern: Add separate class for Mongo connection properties 2016-09-14 19:25:26 +03:00
Ilkka Seppälä
e685512ed5 Hexagonal pattern: Added Mongo based banking adapter and bound it in Guice production module 2016-09-11 23:19:02 +03:00
Ilkka Seppälä
59e6a0af85 Hexagonal pattern: Ignore Mongo repository test 2016-09-11 22:16:50 +03:00
Ilkka Seppälä
626c56730c Hexagonal pattern: Added Mongo based ticket repository and set production configuration to use that 2016-09-11 20:02:34 +03:00
Ilkka Seppälä
4410419914 Hexagonal pattern: Simplified lottery ticket ids 2016-09-11 10:34:12 +03:00
Ilkka Seppälä
e17d72bca8 Hexagonal pattern: Added console interfaces for players and administration. 2016-09-10 14:28:05 +03:00
Ilkka Seppälä
121ed3cca8 Hexagonal pattern: Move lottery administration and service to the core. Introduce console interfaces for players and administartors. 2016-09-10 07:56:37 +03:00
Ilkka Seppälä
adc6019c7e Hexagonal pattern: Remove interfaces with only one implementation 2016-09-10 07:14:24 +03:00
Ilkka Seppälä
0f2807b9cf Hexagonal pattern: More descriptive class names 2016-09-09 21:36:17 +03:00
Ilkka Seppälä
1b10ddbb73 Hexagonal pattern: Use Guice dependency injection 2016-09-06 22:39:39 +03:00
Ilkka Seppälä
3cb872807e Hexagonal pattern: remove unnecessary repository usage from a unit test 2016-09-04 10:33:26 +03:00