reorganize: x-tba

This commit is contained in:
Inanc Gumus
2019-04-24 22:33:54 +03:00
parent cbd28126ea
commit f337a14154
12 changed files with 2 additions and 357 deletions

View File

@ -96,7 +96,7 @@ func (p *parser) parse(line string) (dom domain, err error) {
fields := strings.Fields(line) fields := strings.Fields(line)
if len(fields) != 2 { if len(fields) != 2 {
err = fmt.Errorf("wrong input: %v (line #%d)", fields, p.lines) err = fmt.Errorf("wrong input: %v (line #%d)", fields, p.lines)
return dom, err return
} }
name, visits := fields[0], fields[1] name, visits := fields[0], fields[1]
@ -104,7 +104,7 @@ func (p *parser) parse(line string) (dom domain, err error) {
n, err := strconv.Atoi(visits) n, err := strconv.Atoi(visits)
if n < 0 || err != nil { if n < 0 || err != nil {
err = fmt.Errorf("wrong input: %q (line #%d)", visits, p.lines) err = fmt.Errorf("wrong input: %q (line #%d)", visits, p.lines)
return dom, err return
} }
return domain{name: name, visits: n}, nil return domain{name: name, visits: n}, nil

View File

@ -1,70 +0,0 @@
// For more tutorials: https://blog.learngoprogramming.com
//
// Copyright © 2018 Inanc Gumus
// Learn Go Programming Course
// License: https://creativecommons.org/licenses/by-nc-sa/4.0/
//
package main
import (
"bufio"
"fmt"
"os"
)
func main() {
in := bufio.NewScanner(os.Stdin)
p := newParser()
for in.Scan() {
// dom, err := parse(p, in.Text())
// if err != nil {
// fmt.Println(err)
// return
// }
// p = push(p, dom)
p = add(p, in.Text())
}
summarize(p)
dumpErrs(in.Err(), err(p))
}
// funcs not always need to be reused.
// here, it tells about what it does: it summarizes the parsing result.
func summarize(p parser) {
// multiple iterators can be created. each one remembers the last
// read domain record.
next, cur := iterator(p)
for next() {
dom := cur()
fmt.Printf("%-25s -> %d\n", dom.name, dom.visits)
}
fmt.Printf("\n%-25s -> %d\n", "TOTAL", p.total)
}
// // funcs not always need to be reused.
// // here, it tells about what it does: it summarizes the parsing result.
// func summarize(p parser) {
// // Print the visits per domain
// for _, d := range p.domains {
// vis := p.sum[d.name]
// fmt.Printf("%-25s -> %d\n", d.name, vis)
// }
// // Print the total visits for all domains
// fmt.Printf("\n%-25s -> %d\n", "TOTAL", p.total)
// }
// this variadic func simplifies the multiple error handling
func dumpErrs(errs ...error) {
for _, err := range errs {
if err != nil {
fmt.Printf("> Err: %s\n", err)
}
}
}

View File

@ -1,109 +0,0 @@
package main
import (
"fmt"
"strconv"
"strings"
)
// domain represents a domain log record
type domain struct {
name string
visits int
}
// parser parses a log file and provides an iterator to iterate upon the domains
//
// the parser struct is carefully crafted to be usable using its zero values except the map field.
type parser struct {
sum map[string]int // visits per unique domain
domains []domain // unique domain names
total int // total visits to all domains
lines int // number of parsed lines (for the error messages)
err error // saves the last error occurred
}
// newParser creates and returns a new parser.
func newParser() parser {
return parser{sum: make(map[string]int)}
}
func add(p parser, line string) parser {
// if there was a previous error do not add
if p.err != nil {
return p
}
p, dom, err := parse(p, line)
// store only the last error
if err != nil {
p.err = err
return p
}
return push(p, dom)
}
// iterator returns two functions for iterating over domains.
// next = returns true when there are more domains to iterate on.
// cur = returns the current domain
//
// READ METHOD
func iterator(p parser) (next func() bool, cur func() domain) {
// remember the last received line
var last int
next = func() bool {
defer func() { last++ }()
return len(p.domains) > last
}
cur = func() domain {
d := p.domains[last-1]
vis := p.sum[d.name]
// return a copy so the caller cannot change it
return domain{name: d.name, visits: vis}
}
return
}
// error returns the last error occurred
//
// READ METHOD
func err(p parser) error {
return p.err
}
func parse(p parser, line string) (pr parser, dom domain, err error) {
p.lines++ // increase the parsed line counter (only write is here)
fields := strings.Fields(line)
if len(fields) != 2 {
err = fmt.Errorf("wrong input: %v (line #%d)", fields, p.lines)
return p, dom, err
}
name, visits := fields[0], fields[1]
n, err := strconv.Atoi(visits)
if n < 0 || err != nil {
err = fmt.Errorf("wrong input: %q (line #%d)", visits, p.lines)
return p, dom, err
}
return p, domain{name: name, visits: n}, nil
}
func push(p parser, d domain) parser {
// collect the unique domains
if _, ok := p.sum[d.name]; !ok {
p.domains = append(p.domains, d)
}
p.sum[d.name] += d.visits
p.total += d.visits
return p
}

View File

@ -1,6 +0,0 @@
learngoprogramming.com 10
learngoprogramming.com 10
golang.org 4
golang.org 6
blog.golang.org 20
blog.golang.org 10

View File

@ -1,56 +0,0 @@
// For more tutorials: https://blog.learngoprogramming.com
//
// Copyright © 2018 Inanc Gumus
// Learn Go Programming Course
// License: https://creativecommons.org/licenses/by-nc-sa/4.0/
//
package main
import (
"bufio"
"fmt"
"os"
)
func main() {
in := bufio.NewScanner(os.Stdin)
p := newParser()
for in.Scan() {
// dom, err := parse(p, in.Text())
// if err != nil {
// fmt.Println(err)
// return
// }
// p = push(p, dom)
add(p, in.Text())
}
summarize(p)
dumpErrs(in.Err(), err(p))
}
// funcs not always need to be reused.
// here, it tells about what it does: it summarizes the parsing result.
func summarize(p *parser) {
// multiple iterators can be created. each one remembers the last
// read domain record.
next, cur := iterator(p)
for next() {
dom := cur()
fmt.Printf("%-25s -> %d\n", dom.name, dom.visits)
}
fmt.Printf("\n%-25s -> %d\n", "TOTAL", p.total)
}
// this variadic func simplifies the multiple error handling
func dumpErrs(errs ...error) {
for _, err := range errs {
if err != nil {
fmt.Printf("> Err: %s\n", err)
}
}
}

View File

@ -1,108 +0,0 @@
package main
import (
"fmt"
"strconv"
"strings"
)
// domain represents a domain log record
type domain struct {
name string
visits int
}
// parser parses a log file and provides an iterator to iterate upon the domains
//
// the parser struct is carefully crafted to be usable using its zero values except the map field
type parser struct {
sum map[string]int // visits per unique domain
domains []domain // unique domain names
total int // total visits to all domains
lines int // number of parsed lines (for the error messages)
err error // saves the last error occurred
}
// newParser creates and returns a new parser.
func newParser() *parser {
return &parser{sum: make(map[string]int)}
}
func add(p *parser, line string) {
// if there was a previous error do not add
if p.err != nil {
return
}
dom, err := parse(p, line)
// store only the last error
if err != nil {
p.err = err
return
}
push(p, dom)
}
// iterator returns two functions for iterating over domains.
// next = returns true when there are more domains to iterate on.
// cur = returns the current domain
//
// READ METHOD
func iterator(p *parser) (next func() bool, cur func() domain) {
// remember the last received line
var last int
next = func() bool {
defer func() { last++ }()
return len(p.domains) > last
}
cur = func() domain {
d := p.domains[last-1]
vis := p.sum[d.name]
// return a copy so the caller cannot change it
return domain{name: d.name, visits: vis}
}
return
}
// error returns the last error occurred
//
// READ METHOD
func err(p *parser) error {
return p.err
}
func parse(p *parser, line string) (dom domain, err error) {
p.lines++ // increase the parsed line counter (only write is here)
fields := strings.Fields(line)
if len(fields) != 2 {
err = fmt.Errorf("wrong input: %v (line #%d)", fields, p.lines)
return dom, err
}
name, visits := fields[0], fields[1]
n, err := strconv.Atoi(visits)
if n < 0 || err != nil {
err = fmt.Errorf("wrong input: %q (line #%d)", visits, p.lines)
return dom, err
}
return domain{name: name, visits: n}, nil
}
func push(p *parser, d domain) {
// collect the unique domains
if _, ok := p.sum[d.name]; !ok {
p.domains = append(p.domains, d)
}
p.sum[d.name] += d.visits
p.total += d.visits
}

View File

@ -1,6 +0,0 @@
learngoprogramming.com 10
learngoprogramming.com 10
golang.org 4
golang.org 6
blog.golang.org 20
blog.golang.org 10