From 4922ed2aeb6551091a37aedba2126f7ef1308a2f Mon Sep 17 00:00:00 2001 From: DL6ER Date: Wed, 10 Jul 2019 19:02:13 +0200 Subject: [PATCH] Recommend to disable logging to pihole.log on new installs/during reconfigure. Signed-off-by: DL6ER --- automated install/basic-install.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index a4adac94..cc1f26b2 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -74,8 +74,8 @@ regexFile="/etc/pihole/regex.list" # this script can run IPV4_ADDRESS="" IPV6_ADDRESS="" -# By default, query logging is enabled and the dashboard is set to be installed -QUERY_LOGGING=true +# By default, query logging is disabled and the dashboard is set to be installed +QUERY_LOGGING=false INSTALL_WEB_INTERFACE=true PRIVACY_LEVEL=0 @@ -1076,21 +1076,21 @@ setLogging() { local LogChoices # Ask if the user wants to log queries - LogToggleCommand=(whiptail --separate-output --radiolist "Do you want to log queries?" "${r}" "${c}" 6) - # The default selection is on - LogChooseOptions=("On (Recommended)" "" on - Off "" off) + LogToggleCommand=(whiptail --separate-output --radiolist "Do you want to log queries to pihole.log?" "${r}" "${c}" 6) + # The default selection is off to reduce stressing the SD card + LogChooseOptions=("Off (Recommended)" "" on + "On" "" off) # Get the user's choice LogChoices=$("${LogToggleCommand[@]}" "${LogChooseOptions[@]}" 2>&1 >/dev/tty) || (printf " %bCancel was selected, exiting installer%b\\n" "${COL_LIGHT_RED}" "${COL_NC}" && exit 1) case ${LogChoices} in # If it's on - "On (Recommended)") + "On") printf " %b Logging On.\\n" "${INFO}" # Set the GLOBAL variable to true so we know what they selected QUERY_LOGGING=true ;; # Otherwise, it's off, - Off) + "Off (Recommended)") printf " %b Logging Off.\\n" "${INFO}" # So set it to false QUERY_LOGGING=false