Address review comments
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
This commit is contained in:
@@ -56,11 +56,11 @@ addOrEditKeyValPair() {
|
||||
# Deletes a key from target file
|
||||
#
|
||||
# Example usage:
|
||||
# removeKey "PIHOLE_DNS_1" "/etc/pihole/setupVars.conf"
|
||||
# removeKey "/etc/pihole/setupVars.conf" "PIHOLE_DNS_1"
|
||||
#######################
|
||||
removeKey() {
|
||||
local key="${1}"
|
||||
local file="${2}"
|
||||
local file="${1}"
|
||||
local key="${2}"
|
||||
sed -i "/^${key}/d" "${file}"
|
||||
}
|
||||
|
||||
|
@@ -60,7 +60,7 @@ add_setting() {
|
||||
}
|
||||
|
||||
delete_setting() {
|
||||
removeKey "${1}" "${setupVars}"
|
||||
removeKey "${setupVars}" "${1}"
|
||||
}
|
||||
|
||||
change_setting() {
|
||||
@@ -72,7 +72,7 @@ addFTLsetting() {
|
||||
}
|
||||
|
||||
deleteFTLsetting() {
|
||||
removeKey "${1}" "${FTLconf}"
|
||||
removeKey "${FTLconf}" "${1}"
|
||||
}
|
||||
|
||||
changeFTLsetting() {
|
||||
@@ -84,7 +84,7 @@ add_dnsmasq_setting() {
|
||||
}
|
||||
|
||||
delete_dnsmasq_setting() {
|
||||
removeKey "${1}" "${dnsmasqconfig}"
|
||||
removeKey "${dnsmasqconfig}" "${1}"
|
||||
}
|
||||
|
||||
SetTemperatureUnit() {
|
||||
|
Reference in New Issue
Block a user