Commit Graph

104 Commits

Author SHA1 Message Date
15db1ffdd5 Remove variables not needed any more 2016-12-24 15:48:43 +01:00
4632b0f797 Updated updater logic 2016-12-24 15:40:31 +01:00
65c35a5530 Use new subroutine to determine if updates are available 2016-12-24 15:32:25 +01:00
c449a1c0e0 Added GitCheckUpdateAvail() 2016-12-24 15:19:39 +01:00
b020010f0d Removed some of the &> /dev/null 2016-12-24 15:08:30 +01:00
0276c72fe2 replace 'git -C' with long version (see #1009) 2016-12-24 15:05:57 +01:00
2f976504e8 switch out -eq for == 2016-11-02 20:06:21 +00:00
f7d0de53bb Compare string to string. 2016-11-02 12:11:34 -07:00
603ec997ba Remove testing block. 2016-11-02 12:09:33 -07:00
f7266ef4c8 Version remote check returns -1 on failure to detect curl silent failing. Update detects loss of contact to GitHub or fallthrough condition and reports to user. 2016-11-02 12:07:59 -07:00
3d43e1568c Use explicit calls for function to self-document 2016-11-02 11:39:22 -07:00
c1a3f003e8 Rename the only utilty function left that didn't say repo 2016-11-02 11:18:13 -07:00
3f61aea7fc Utility functions fully quiet now. Calling functions have the echos. 2016-11-02 11:09:53 -07:00
bd68db51e0 ShellCheck split local declaration and assignment. 2016-11-02 11:01:50 -07:00
b8a5ed710e Take echos out of utility functions and move up a level. 2016-11-02 10:51:09 -07:00
34be601dd7 Test for lexicographically less than tag version. 2016-11-02 10:42:05 -07:00
1d64ad1ccd Stash all changed files, clean directory and pull updates. 2016-11-02 10:39:27 -07:00
f2d7a3d26d Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks 2016-11-02 09:48:00 -07:00
ee37c37cab fix update output logic. version number variables should not be read only! 2016-11-02 14:29:20 +00:00
b636c1e1f8 Whitespace. 2016-11-02 07:00:43 -07:00
8b9f0487c0 Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks
# Conflicts:
#	advanced/Scripts/update.sh
#	automated install/basic-install.sh
2016-11-02 06:57:33 -07:00
ece1667fb0 Refactor and move some bits. 2016-11-02 06:41:51 -07:00
50bd8b4a09 Further tweaks to local repo handling 2016-11-02 13:34:57 +00:00
93d91353a1 All tabs now spaced 2016-11-02 05:49:33 -07:00
8dc9143b34 Just delete, no need to cd there first. 2016-11-02 05:45:29 -07:00
a0d9a1133c Factoring and combining functions 2016-11-02 05:34:39 -07:00
035e4bf727 Move value checks to if calls. 2016-11-02 03:55:04 -07:00
9ec5bbd560 Actually get is_repo to return a value and have it expected. 2016-11-02 03:38:35 -07:00
34482c5ed6 Modified is_repo 2016-11-02 03:09:59 -07:00
7d414b5628 Move version messages to main function, check for repos. 2016-11-02 01:12:02 -07:00
d9528dfd09 Bash is funny with returns. 2016-11-02 00:51:38 -07:00
9c83825cb8 Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks 2016-11-01 22:20:32 -07:00
7a22471787 New naming convention, and reorder functions as bash would prefer them to be. 2016-11-01 22:19:40 -07:00
c30478bf4a cleanup and use sentintel in is_repo 2016-11-01 23:21:50 -05:00
d986746ef9 missing quote added 2016-11-01 23:07:20 -05:00
a8fa061f2e quote all the assignments prevent accidental glob splitting 2016-11-01 23:02:06 -05:00
bdd240ecb6 Shellcheck catch for always true expansion. 2016-11-01 15:36:27 -07:00
04da292df9 Missed one spinner, updated and exit script if github is unreachable. 2016-11-01 12:17:38 -07:00
85b8676b8e Remove spinner, no functions here should last that long, and it masks a few potential exit avenues. 2016-11-01 12:16:46 -07:00
114bc13c23 Specify path, cron may not know where the files are located. 2016-11-01 12:03:26 -07:00
5fef5f1ed4 Break down is_repo to make sure it does what is expected. 2016-11-01 11:54:14 -07:00
807b60b0e6 Missed the second reinstaller.... 2016-11-01 11:44:16 -07:00
fbc800e556 If unattened reinstall fails, notify user and exit script immediately. 2016-11-01 11:42:18 -07:00
1991ee7a7d Google Style Guide. readonly and cap constants. 2016-11-01 11:36:44 -07:00
ffbfadbccf Detail what the script does. 2016-11-01 11:33:04 -07:00
c3e2bce956 Variables declared as strings, make sure they are strings when we use them in functions. 2016-11-01 11:26:57 -07:00
0c9520d7e3 Protect against unexepcted return values (GitHub not responding as we'd expect.) And make sure bash doesn't maul the variables and cause firing of unattended reinstall of application when values returned aren't as expected. 2016-11-01 11:18:41 -07:00
1e7e5230cc Clarify what exactly is being called and the expected returned value format 2016-11-01 11:15:21 -07:00
f1efc97357 Clairfy condition to make sure they operate as per the specs of the logic flow layout. 2016-11-01 11:04:33 -07:00
69ba8a3c2f Consistency
Again trying to move the repo to one style. Doesn't matter if it's
changed afterwards, but one style instead of about five seems
saner.
2016-10-22 10:01:15 -07:00