f9250d91a5
Explictly escape the escape.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-06 19:17:13 +01:00
491c828661
Improved code, ensure that gravity.sh passes shellcheck as a whole
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-06 19:09:09 +01:00
644ec36e64
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-06 18:57:48 +01:00
838e1b19ec
basic_install: Set permissons for PI_HOLE_DASHBOARD_DIR
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-06 10:41:37 +01:00
d5bbb2b640
basic_install: Use a varibale for the pihole dashboard dir
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-06 10:40:47 +01:00
dc91d4b1f9
basic_install: If a static interface is already set up we are done
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-06 07:50:21 +01:00
9984647ebb
After renaming column in regex, it also needs to be renamed in vw_regex
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:41:11 +01:00
ec5b16ef85
Fix incomplete comment
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:08:08 +01:00
c3c60e10f1
Rename regex field from domain to filter because this described better what it is
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:07:12 +01:00
8a2363621d
Rename fields from DateAdded to dateadded
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:06:46 +01:00
dbbf21071b
Invert logic to use ENABLED instead of DISABLED. We make sure to set "enabled = 1 WHERE enabled IS NULL" in gravity_store_in_database()
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:05:11 +01:00
e967fe2266
Merge pull request #2612 from pi-hole/hotfix/v4.2.1
...
Remove user/group from dnsmasq config
2019-02-03 11:36:57 -08:00
b5c7657e01
Merge pull request #2614 from pi-hole/hotfix/v4.2.1
...
Merge v4.2.1 hotfix to dev
2019-02-03 11:36:00 -08:00
680d6e2d31
Merge branch 'release/v4.2' into development
...
# Conflicts:
# automated install/basic-install.sh
2019-02-03 11:14:09 -08:00
7a19d24058
Remove user/group from dnsmasq config
...
In the case that FTL is started under root, dnsmasq changes the user to
pihole due to this setting. The shared memory is created before this
switch, and may cause issues such as failing to delete or reallocate
the shared memory.
These config lines were necessary before dnsmasq became part of FTL, but
now since dnsmasq runs under FTL, we can configure the user/group
through FTL.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-02-03 10:55:18 -08:00
995ee41d6b
Merge pull request #2600 from pi-hole/release/v4.2
...
Release v4.2
2019-02-03 08:52:07 -08:00
b2f4385232
Avoid infinity loop if gravity optimization fails
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 17:05:00 +01:00
1f9a7d0b0c
Only run VACUUM on "pihole -g -o"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 17:01:38 +01:00
d5feffa117
Do not backup the database
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 16:45:19 +01:00
fc62cf7e2f
Only run VACUUM on "full" gravity runs
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 16:45:06 +01:00
93f1859bab
Store regex in gravity.db as well
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 15:13:18 +01:00
dcf0a605cf
Use views for all tables and set disabled column to false for those tables that support it
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 14:14:14 +01:00
710036adae
Add DISABLED field to white- and blacklist defaulting to false. The two views respect the DISABLED fields for both lists.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 13:34:08 +01:00
8a91fe6992
Store domains in gravit tables: gravity, whitelist, blacklist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 13:21:26 +01:00
09c4c88a6d
Create and fill gravity.db during pihole -g
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 13:04:31 +01:00
69919ac85c
Merge pull request #2610 from pi-hole/fix/dev-shm
...
Change /var/run/shm to /dev/shm
2019-02-02 13:44:39 -05:00
26f2410fe6
Change /var/run/shm to /dev/shm
...
The /var directory may not exist (does not exist on Fedora 29), and is
simply a symlink to /dev/shm.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-02-02 10:37:12 -08:00
d43c32e9e8
Merge pull request #2609 from pi-hole/fix/start-service-ftl-checkout
...
Fix missed start_service -> restart_service call
2019-02-02 18:27:09 +00:00
5c4ee23795
Fix missed start_service -> restart_service call
...
start_service was changed to restart_service.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-02-02 10:19:44 -08:00
fb3d871553
Merge pull request #2602 from pi-hole/fix/download_FTL_earlier
...
Download FTL earlier in the installer
2019-02-02 06:43:16 -08:00
ae654730c4
Update automated install/basic-install.sh
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
2019-02-02 08:00:58 +01:00
ec79e86bee
We should really use stop_service as it also includes some nice output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-01 18:06:57 +01:00
e8dabc71af
Don't try to start pihole-FTL after it has been installed. This will be done a few moments later when gravity is invoked.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-01 17:54:21 +01:00
9c0de0f731
Try to stop pihole-FTL before and (re)start pihole-FTL after the install command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-01 17:39:12 +01:00
4948862dce
Fail hard if FTL binary could not be installed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-31 20:10:52 +01:00
7479485d45
Add test for the case the binary variable is unset (defaults to "tbd" in this case)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-31 20:00:26 +01:00
1e284f69ea
Merge pull request #2587 from pi-hole/new/network-table
...
Download macvendor database
2019-01-28 20:27:13 -05:00
516ed83638
Add "|| true" to the curl command as a failed download is no show-stopper for the overall install process.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-28 20:48:30 +01:00
26361883b4
Merge pull request #2601 from pi-hole/fix/double_disable_kills_gravity
...
Prevent double disabling/enabling
2019-01-27 13:54:33 -05:00
d26f2dcb2c
Use global binary variable in tests for automated install
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:47:28 +01:00
cc657c0c26
Rename subroutine start_service() to restart_service() because this is what it does
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:37:03 +01:00
d90d7b6927
Call FTL download/installation early on in the installation process.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:36:27 +01:00
de6dc90575
Don't diable pihole-FTL before calling install. root should be able to overwrite the binary in any case. The binary has already been downloaded and hash-verified here so we don't expect any errors in this binary.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:32:33 +01:00
3cdd6204c5
Move dnsmasq disabling and config file rewriting into a dedicated subroutine
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:31:02 +01:00
d996e9c9ee
Fix inconsistent handling of binary variable. get_binary_variable() stores the result into a global variable we pass later on as argument to FTLinstall() and define a local variable with the same name. This is fixed by only using the globa variable in all places not. This is still not a very elegant solution but it is also not subject of the current PR.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:28:09 +01:00
a4ba8d4b8f
Prevent double disabling/enabling by checking BLOCKING_ENABLED value in setupVars.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:16:24 +01:00
cd8a423b32
Solves RegEx issue and updates documentation.
...
Signed-off-by: xch12i5 <40517505+xCh12i5@users.noreply.github.com >
2019-01-20 16:09:25 +01:00
f7ca74cf1d
Merge pull request #2598 from pi-hole/fix/remove-norton
...
Remove Norton DNS
2019-01-19 20:52:37 -05:00
ebba32e1c4
Remove Norton DNS
...
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2019-01-19 20:45:19 -05:00
e02da90faa
Replaces double quotes by single quotes and updates documentation.
...
Signed-off-by: xch12i5 <40517505+xCh12i5@users.noreply.github.com >
2019-01-19 17:52:28 +01:00
