gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unnecessary parameter element (#4666)

Browse Source 
* Stop passing pubkey ref unnecessarily

* Cargo.lock
This commit is contained in:
Tyera Eulberg
2019-06-12 16:18:27 -06:00
committed by GitHub
parent c1f316721a
commit 0da9ac1a47
3 changed files with 36 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
runtime/src/accounts_db.rs
View File

@ -435,7 +435,7 @@ impl AccountsDB {
fork_id: Fork,
accounts: &HashMap<&Pubkey, (&Account, LamportCredit)>,
) -> Vec<AccountInfo> {
let with_meta: Vec<(StorageMeta, &Pubkey, &Account, u64)> = accounts
let with_meta: Vec<(StorageMeta, &Account, u64)> = accounts
.iter()
.map(|(pubkey, (account, credit))| {
let write_version = self.write_version.fetch_add(1, Ordering::Relaxed) as u64;
@ -457,7 +457,7 @@ impl AccountsDB {
lamports += credit;
}
(meta, *pubkey, *account, lamports)
(meta, *account, lamports)
})
.collect();
let mut infos: Vec<AccountInfo> = vec![];
@ -468,7 +468,7 @@ impl AccountsDB {
storage.set_status(AccountStorageStatus::Full);
continue;
}
for (offset, (_, _, _, lamports)) in rvs.iter().zip(&with_meta[infos.len()..]) {
for (offset, (_, _, lamports)) in rvs.iter().zip(&with_meta[infos.len()..]) {
storage.add_account();
infos.push(AccountInfo {
id: storage.id,

9
runtime/src/append_vec.rs
View File

@ -220,13 +220,10 @@ impl AppendVec {
}
#[allow(clippy::mutex_atomic)]
pub fn append_accounts(
&self,
accounts: &[(StorageMeta, &Pubkey, &Account, u64)],
) -> Vec<usize> {
pub fn append_accounts(&self, accounts: &[(StorageMeta, &Account, u64)]) -> Vec<usize> {
let mut offset = self.append_offset.lock().unwrap();
let mut rv = vec![];
for (storage_meta, _, account, lamports) in accounts {
for (storage_meta, account, lamports) in accounts {
let meta_ptr = storage_meta as *const StorageMeta;
let balance = AccountBalance {
lamports: *lamports,
@ -251,7 +248,7 @@ impl AppendVec {
}
pub fn append_account(&self, storage_meta: StorageMeta, account: &Account) -> Option<usize> {
self.append_accounts(&[(storage_meta, &Pubkey::default(), account, account.lamports)])
self.append_accounts(&[(storage_meta, account, account.lamports)])
.first()
.cloned()
}