gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update default subscription commitment level from recent to single (#10161)

Browse Source 
* Update default subscription commitment level from recent to single

* Update jsonrpc docs

* Fix failing tests
This commit is contained in:
Justin Starry
2020-05-22 00:33:24 +08:00
committed by GitHub
parent 77d42654dc
commit 10d60288e8
3 changed files with 104 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/rpc_pubsub.rs
View File

@ -555,7 +555,7 @@ mod tests {
session,
subscriber,
contract_state.pubkey().to_string(),
None,
Some(CommitmentConfig::recent()),
);
let tx = system_transaction::transfer(&alice, &contract_funds.pubkey(), 51, blockhash);

11
core/src/rpc_subscriptions.rs
View File

@ -102,7 +102,7 @@ fn add_subscription<K, S>(
S: Clone,
{
let sink = subscriber.assign_id(sub_id.clone()).unwrap();
let commitment = commitment.unwrap_or_else(CommitmentConfig::recent);
let commitment = commitment.unwrap_or_else(CommitmentConfig::single);
let subscription_data = SubscriptionData {
sink,
commitment,
@ -429,7 +429,7 @@ impl RpcSubscriptions {
) {
let mut subscriptions = self.subscriptions.account_subscriptions.write().unwrap();
let slot = match commitment
.unwrap_or_else(CommitmentConfig::recent)
.unwrap_or_else(CommitmentConfig::single)
.commitment
{
CommitmentLevel::Max => self
@ -778,7 +778,12 @@ pub(crate) mod tests {
),
)),
);
subscriptions.add_account_subscription(alice.pubkey(), None, sub_id.clone(), subscriber);
subscriptions.add_account_subscription(
alice.pubkey(),
Some(CommitmentConfig::recent()),
sub_id.clone(),
subscriber,
);
assert!(subscriptions
.subscriptions