From 12bf34f059ae313f0b59e0f8b913b232c3dd5051 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Fri, 13 Mar 2020 16:56:22 -0700 Subject: [PATCH] Remove holding Poh lock (#8838) (#8850) automerge --- core/src/cluster_info_vote_listener.rs | 3 ++- core/src/replay_stage.rs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/cluster_info_vote_listener.rs b/core/src/cluster_info_vote_listener.rs index ce9882718b..c5cd8d5124 100644 --- a/core/src/cluster_info_vote_listener.rs +++ b/core/src/cluster_info_vote_listener.rs @@ -51,7 +51,8 @@ impl ClusterInfoVoteListener { if exit.load(Ordering::Relaxed) { return Ok(()); } - if let Some(bank) = poh_recorder.lock().unwrap().bank() { + let poh_bank = poh_recorder.lock().unwrap().bank(); + if let Some(bank) = poh_bank { let last_ts = bank.last_vote_sync.load(Ordering::Relaxed); let (votes, new_ts) = cluster_info.read().unwrap().get_votes(last_ts); bank.last_vote_sync diff --git a/core/src/replay_stage.rs b/core/src/replay_stage.rs index ffdefc5166..7beaed180a 100644 --- a/core/src/replay_stage.rs +++ b/core/src/replay_stage.rs @@ -395,7 +395,8 @@ impl ReplayStage { rewards_recorder_sender.clone(), ); - if let Some(bank) = poh_recorder.lock().unwrap().bank() { + let poh_bank = poh_recorder.lock().unwrap().bank(); + if let Some(bank) = poh_bank { Self::log_leader_change( &my_pubkey, bank.slot(),