From 177d2411608873c8f6585969c70f475e89543d8a Mon Sep 17 00:00:00 2001 From: Vladimir Komendantskiy Date: Thu, 30 Jul 2020 13:54:39 +0100 Subject: [PATCH] use replace value --- logger/src/lib.rs | 2 +- metrics/src/metrics.rs | 2 +- programs/budget/src/budget_expr.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/logger/src/lib.rs b/logger/src/lib.rs index 2c456fd292..81da2f440b 100644 --- a/logger/src/lib.rs +++ b/logger/src/lib.rs @@ -26,7 +26,7 @@ fn replace_logger(logger: env_logger::Logger) { let max_level = logger.filter(); log::set_max_level(max_level); let mut rw = LOGGER.write().unwrap(); - std::mem::replace(&mut *rw, logger); + let _ = std::mem::replace(&mut *rw, logger); let _ = log::set_boxed_logger(Box::new(LoggerShim {})); } diff --git a/metrics/src/metrics.rs b/metrics/src/metrics.rs index c77f56c7a5..7a02cc73a5 100644 --- a/metrics/src/metrics.rs +++ b/metrics/src/metrics.rs @@ -334,7 +334,7 @@ lazy_static! { pub fn set_host_id(host_id: String) { let mut rw = HOST_ID.write().unwrap(); info!("host id: {}", host_id); - std::mem::replace(&mut *rw, host_id); + let _ = std::mem::replace(&mut *rw, host_id); } /// Submits a new point from any thread. Note that points are internally queued diff --git a/programs/budget/src/budget_expr.rs b/programs/budget/src/budget_expr.rs index 413f7ae35d..b8cbec5c69 100644 --- a/programs/budget/src/budget_expr.rs +++ b/programs/budget/src/budget_expr.rs @@ -256,7 +256,7 @@ impl BudgetExpr { _ => None, }; if let Some(expr) = new_expr { - mem::replace(self, *expr); + let _ = mem::replace(self, *expr); } } }