Wrap derivation_path::DerivationPath (#16609)
* Replace custom DerivationPath impl * Add method to parse full-path from str with hardening * Convert Bip44 to trait * Hoist more work on derivation-path * Privatize Bip44 trait
This commit is contained in:
@ -1,8 +1,13 @@
|
||||
use {
|
||||
core::{iter::IntoIterator, slice::Iter},
|
||||
derivation_path::{ChildIndex, DerivationPath as DerivationPathInner},
|
||||
std::{fmt, str::FromStr},
|
||||
thiserror::Error,
|
||||
};
|
||||
|
||||
const ACCOUNT_INDEX: usize = 2;
|
||||
const CHANGE_INDEX: usize = 3;
|
||||
|
||||
/// Derivation path error.
|
||||
#[derive(Error, Debug, Clone)]
|
||||
pub enum DerivationPathError {
|
||||
@ -10,85 +15,84 @@ pub enum DerivationPathError {
|
||||
InvalidDerivationPath(String),
|
||||
}
|
||||
|
||||
#[derive(Clone, Default, PartialEq)]
|
||||
pub struct DerivationPathComponent(u32);
|
||||
#[derive(PartialEq)]
|
||||
pub struct DerivationPath(DerivationPathInner);
|
||||
|
||||
impl DerivationPathComponent {
|
||||
pub const HARDENED_BIT: u32 = 1 << 31;
|
||||
|
||||
pub fn as_u32(&self) -> u32 {
|
||||
self.0
|
||||
}
|
||||
}
|
||||
|
||||
impl From<u32> for DerivationPathComponent {
|
||||
fn from(n: u32) -> Self {
|
||||
Self(n | Self::HARDENED_BIT)
|
||||
}
|
||||
}
|
||||
|
||||
impl FromStr for DerivationPathComponent {
|
||||
type Err = DerivationPathError;
|
||||
|
||||
fn from_str(s: &str) -> Result<Self, Self::Err> {
|
||||
let index_str = if let Some(stripped) = s.strip_suffix('\'') {
|
||||
stripped
|
||||
} else {
|
||||
s
|
||||
};
|
||||
index_str.parse::<u32>().map(|ki| ki.into()).map_err(|_| {
|
||||
DerivationPathError::InvalidDerivationPath(format!(
|
||||
"failed to parse path component: {:?}",
|
||||
s
|
||||
))
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
impl std::fmt::Display for DerivationPathComponent {
|
||||
fn fmt(&self, fmt: &mut std::fmt::Formatter) -> std::fmt::Result {
|
||||
let hardened = if (self.0 & Self::HARDENED_BIT) == 0 {
|
||||
""
|
||||
} else {
|
||||
"'"
|
||||
};
|
||||
let index = self.0 & !Self::HARDENED_BIT;
|
||||
write!(fmt, "{}{}", index, hardened)
|
||||
}
|
||||
}
|
||||
|
||||
impl std::fmt::Debug for DerivationPathComponent {
|
||||
fn fmt(&self, fmt: &mut std::fmt::Formatter) -> std::fmt::Result {
|
||||
std::fmt::Display::fmt(self, fmt)
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Default, PartialEq, Clone)]
|
||||
pub struct DerivationPath {
|
||||
pub account: Option<DerivationPathComponent>,
|
||||
pub change: Option<DerivationPathComponent>,
|
||||
}
|
||||
|
||||
impl fmt::Debug for DerivationPath {
|
||||
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
||||
let account = if let Some(account) = &self.account {
|
||||
format!("/{:?}", account)
|
||||
} else {
|
||||
"".to_string()
|
||||
};
|
||||
let change = if let Some(change) = &self.change {
|
||||
format!("/{:?}", change)
|
||||
} else {
|
||||
"".to_string()
|
||||
};
|
||||
write!(f, "m/44'/501'{}{}", account, change)
|
||||
impl Default for DerivationPath {
|
||||
fn default() -> Self {
|
||||
Self::new_bip44(None, None)
|
||||
}
|
||||
}
|
||||
|
||||
impl DerivationPath {
|
||||
fn new<P: Into<Box<[ChildIndex]>>>(path: P) -> Self {
|
||||
Self(DerivationPathInner::new(path))
|
||||
}
|
||||
|
||||
pub fn from_key_str(path: &str) -> Result<Self, DerivationPathError> {
|
||||
Self::from_key_str_with_coin(path, Solana)
|
||||
}
|
||||
|
||||
fn from_key_str_with_coin<T: Bip44>(path: &str, coin: T) -> Result<Self, DerivationPathError> {
|
||||
let path = format!("m/{}", path);
|
||||
let extend = DerivationPathInner::from_str(&path)
|
||||
.map_err(|err| DerivationPathError::InvalidDerivationPath(err.to_string()))?;
|
||||
let mut extend = extend.into_iter();
|
||||
let account = extend.next().map(|index| index.to_u32());
|
||||
let change = extend.next().map(|index| index.to_u32());
|
||||
if extend.next().is_some() {
|
||||
return Err(DerivationPathError::InvalidDerivationPath(format!(
|
||||
"key path `{}` too deep, only <account>/<change> supported",
|
||||
path
|
||||
)));
|
||||
}
|
||||
Ok(Self::new_bip44_with_coin(coin, account, change))
|
||||
}
|
||||
|
||||
fn _from_absolute_path_str(path: &str) -> Result<Self, DerivationPathError> {
|
||||
let inner = DerivationPath::_from_absolute_path_insecure_str(path)?
|
||||
.into_iter()
|
||||
.map(|c| ChildIndex::Hardened(c.to_u32()))
|
||||
.collect::<Vec<_>>();
|
||||
Ok(Self(DerivationPathInner::new(inner)))
|
||||
}
|
||||
|
||||
fn _from_absolute_path_insecure_str(path: &str) -> Result<Self, DerivationPathError> {
|
||||
Ok(Self(DerivationPathInner::from_str(&path).map_err(
|
||||
|err| DerivationPathError::InvalidDerivationPath(err.to_string()),
|
||||
)?))
|
||||
}
|
||||
|
||||
pub fn new_bip44(account: Option<u32>, change: Option<u32>) -> Self {
|
||||
Self::new_bip44_with_coin(Solana, account, change)
|
||||
}
|
||||
|
||||
fn new_bip44_with_coin<T: Bip44>(coin: T, account: Option<u32>, change: Option<u32>) -> Self {
|
||||
let mut indexes = coin.base_indexes();
|
||||
if let Some(account) = account {
|
||||
indexes.push(ChildIndex::Hardened(account));
|
||||
if let Some(change) = change {
|
||||
indexes.push(ChildIndex::Hardened(change));
|
||||
}
|
||||
}
|
||||
Self::new(indexes)
|
||||
}
|
||||
|
||||
pub fn account(&self) -> Option<&ChildIndex> {
|
||||
self.0.path().get(ACCOUNT_INDEX)
|
||||
}
|
||||
|
||||
pub fn change(&self) -> Option<&ChildIndex> {
|
||||
self.0.path().get(CHANGE_INDEX)
|
||||
}
|
||||
|
||||
pub fn path(&self) -> &[ChildIndex] {
|
||||
self.0.path()
|
||||
}
|
||||
|
||||
pub fn get_query(&self) -> String {
|
||||
if let Some(account) = &self.account {
|
||||
if let Some(change) = &self.change {
|
||||
if let Some(account) = &self.account() {
|
||||
if let Some(change) = &self.change() {
|
||||
format!("?key={}/{}", account, change)
|
||||
} else {
|
||||
format!("?key={}", account)
|
||||
@ -99,65 +103,166 @@ impl DerivationPath {
|
||||
}
|
||||
}
|
||||
|
||||
impl fmt::Debug for DerivationPath {
|
||||
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
||||
write!(f, "m")?;
|
||||
for index in self.0.path() {
|
||||
write!(f, "/{}", index)?;
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
||||
impl<'a> IntoIterator for &'a DerivationPath {
|
||||
type IntoIter = Iter<'a, ChildIndex>;
|
||||
type Item = &'a ChildIndex;
|
||||
fn into_iter(self) -> Self::IntoIter {
|
||||
self.0.into_iter()
|
||||
}
|
||||
}
|
||||
|
||||
trait Bip44 {
|
||||
const PURPOSE: u32 = 44;
|
||||
const COIN: u32;
|
||||
|
||||
fn base_indexes(&self) -> Vec<ChildIndex> {
|
||||
vec![
|
||||
ChildIndex::Hardened(Self::PURPOSE),
|
||||
ChildIndex::Hardened(Self::COIN),
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
struct Solana;
|
||||
|
||||
impl Bip44 for Solana {
|
||||
const COIN: u32 = 501;
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
struct TestCoin;
|
||||
impl Bip44 for TestCoin {
|
||||
const COIN: u32 = 999;
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_from_key_str() {
|
||||
let s = "1/2";
|
||||
assert_eq!(
|
||||
DerivationPath::from_key_str_with_coin(s, TestCoin).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), Some(2))
|
||||
);
|
||||
let s = "1'/2'";
|
||||
assert_eq!(
|
||||
DerivationPath::from_key_str_with_coin(s, TestCoin).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), Some(2))
|
||||
);
|
||||
let s = "1\'/2\'";
|
||||
assert_eq!(
|
||||
DerivationPath::from_key_str_with_coin(s, TestCoin).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), Some(2))
|
||||
);
|
||||
let s = "1";
|
||||
assert_eq!(
|
||||
DerivationPath::from_key_str_with_coin(s, TestCoin).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), None)
|
||||
);
|
||||
let s = "1'";
|
||||
assert_eq!(
|
||||
DerivationPath::from_key_str_with_coin(s, TestCoin).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), None)
|
||||
);
|
||||
let s = "1\'";
|
||||
assert_eq!(
|
||||
DerivationPath::from_key_str_with_coin(s, TestCoin).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), None)
|
||||
);
|
||||
|
||||
assert!(DerivationPath::from_key_str_with_coin("1/2/3", TestCoin).is_err());
|
||||
assert!(DerivationPath::from_key_str_with_coin("other", TestCoin).is_err());
|
||||
assert!(DerivationPath::from_key_str_with_coin("1o", TestCoin).is_err());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_from_absolute_path_str() {
|
||||
let s = "m/44/501";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::default()
|
||||
);
|
||||
let s = "m/44'/501'";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::default()
|
||||
);
|
||||
let s = "m/44'/501'/1/2";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::new_bip44(Some(1), Some(2))
|
||||
);
|
||||
let s = "m/44'/501'/1'/2'";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::new_bip44(Some(1), Some(2))
|
||||
);
|
||||
|
||||
// Test non-Solana Bip44
|
||||
let s = "m/44'/999'/1/2";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), Some(2))
|
||||
);
|
||||
let s = "m/44'/999'/1'/2'";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::new_bip44_with_coin(TestCoin, Some(1), Some(2))
|
||||
);
|
||||
|
||||
// Test non-bip44 paths
|
||||
let s = "m/501'/0'/0/0";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::new(vec![
|
||||
ChildIndex::Hardened(501),
|
||||
ChildIndex::Hardened(0),
|
||||
ChildIndex::Hardened(0),
|
||||
ChildIndex::Hardened(0),
|
||||
])
|
||||
);
|
||||
let s = "m/501'/0'/0'/0'";
|
||||
assert_eq!(
|
||||
DerivationPath::_from_absolute_path_str(s).unwrap(),
|
||||
DerivationPath::new(vec![
|
||||
ChildIndex::Hardened(501),
|
||||
ChildIndex::Hardened(0),
|
||||
ChildIndex::Hardened(0),
|
||||
ChildIndex::Hardened(0),
|
||||
])
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_get_query() {
|
||||
let derivation_path = DerivationPath {
|
||||
account: None,
|
||||
change: None,
|
||||
};
|
||||
let derivation_path = DerivationPath::new_bip44_with_coin(TestCoin, None, None);
|
||||
assert_eq!(derivation_path.get_query(), "".to_string());
|
||||
let derivation_path = DerivationPath {
|
||||
account: Some(1.into()),
|
||||
change: None,
|
||||
};
|
||||
assert_eq!(
|
||||
derivation_path.get_query(),
|
||||
format!("?key={}", DerivationPathComponent::from(1))
|
||||
);
|
||||
let derivation_path = DerivationPath {
|
||||
account: Some(1.into()),
|
||||
change: Some(2.into()),
|
||||
};
|
||||
assert_eq!(
|
||||
derivation_path.get_query(),
|
||||
format!(
|
||||
"?key={}/{}",
|
||||
DerivationPathComponent::from(1),
|
||||
DerivationPathComponent::from(2)
|
||||
)
|
||||
);
|
||||
let derivation_path = DerivationPath::new_bip44_with_coin(TestCoin, Some(1), None);
|
||||
assert_eq!(derivation_path.get_query(), "?key=1'".to_string());
|
||||
let derivation_path = DerivationPath::new_bip44_with_coin(TestCoin, Some(1), Some(2));
|
||||
assert_eq!(derivation_path.get_query(), "?key=1'/2'".to_string());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_derivation_path_debug() {
|
||||
let mut path = DerivationPath::default();
|
||||
let path = DerivationPath::default();
|
||||
assert_eq!(format!("{:?}", path), "m/44'/501'".to_string());
|
||||
|
||||
path.account = Some(1.into());
|
||||
let path = DerivationPath::new_bip44(Some(1), None);
|
||||
assert_eq!(format!("{:?}", path), "m/44'/501'/1'".to_string());
|
||||
|
||||
path.change = Some(2.into());
|
||||
let path = DerivationPath::new_bip44(Some(1), Some(2));
|
||||
assert_eq!(format!("{:?}", path), "m/44'/501'/1'/2'".to_string());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_derivation_path_component() {
|
||||
let f = DerivationPathComponent::from(1);
|
||||
assert_eq!(f.as_u32(), 1 | DerivationPathComponent::HARDENED_BIT);
|
||||
|
||||
let fs = DerivationPathComponent::from_str("1").unwrap();
|
||||
assert_eq!(fs, f);
|
||||
|
||||
let fs = DerivationPathComponent::from_str("1'").unwrap();
|
||||
assert_eq!(fs, f);
|
||||
|
||||
assert!(DerivationPathComponent::from_str("-1").is_err());
|
||||
|
||||
assert_eq!(format!("{}", f), "1'".to_string());
|
||||
assert_eq!(format!("{:?}", f), "1'".to_string());
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user