Remove fee-payer guesswork from Message and Transaction (#10776)

* Make Message::new_with_payer the default constructor

* Remove Transaction::new_[un]signed_instructions

These guess the fee-payer instead of stating it explicitly

tokens/src/commands.rs

@@ -158,7 +158,7 @@ fn distribute_tokens(
         };
 
         let fee_payer_pubkey = args.fee_payer.pubkey();
-        let message = Message::new_with_payer(&instructions, Some(&fee_payer_pubkey));
+        let message = Message::new(&instructions, Some(&fee_payer_pubkey));
         match client.send_message(message, &signers) {
             Ok((transaction, last_valid_slot)) => {
                 db::set_transaction_info(
@@ -508,7 +508,7 @@ pub fn test_process_distribute_stake_with_client<C: Client>(client: C, sender_ke
         &lockup,
         sol_to_lamports(3000.0),
     );
-    let message = Message::new(&instructions);
+    let message = Message::new(&instructions, Some(&sender_keypair.pubkey()));
     let signers = [&sender_keypair, &stake_account_keypair];
     thin_client.send_message(message, &signers).unwrap();
 

tokens/src/thin_client.rs

@@ -171,7 +171,7 @@ impl<'a> ThinClient<'a> {
     ) -> Result<(Transaction, u64)> {
         let create_instruction =
             system_instruction::transfer(&sender_keypair.pubkey(), &to_pubkey, lamports);
-        let message = Message::new(&[create_instruction]);
+        let message = Message::new(&[create_instruction], Some(&sender_keypair.pubkey()));
         self.send_message(message, &[sender_keypair])
     }