From 38a3ed96bb537f070fccc3b905ec78fb45e8c8d1 Mon Sep 17 00:00:00 2001
From: Tyera Eulberg <teulberg@gmail.com>
Date: Mon, 23 Nov 2020 13:13:38 -0700
Subject: [PATCH] Fail stake init if account data is the wrong size (#13767)

---
 programs/stake/src/stake_state.rs | 40 +++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/programs/stake/src/stake_state.rs b/programs/stake/src/stake_state.rs
index 9208738e69..cf80b452c8 100644
--- a/programs/stake/src/stake_state.rs
+++ b/programs/stake/src/stake_state.rs
@@ -805,6 +805,9 @@ impl<'a> StakeAccount for KeyedAccount<'a> {
         lockup: &Lockup,
         rent: &Rent,
     ) -> Result<(), InstructionError> {
+        if self.data_len()? != std::mem::size_of::<StakeState>() {
+            return Err(InstructionError::InvalidAccountData);
+        }
         if let StakeState::Uninitialized = self.state()? {
             let rent_exempt_reserve = rent.minimum_balance(self.data_len()?);
 
@@ -2168,6 +2171,43 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_initialize_incorrect_account_sizes() {
+        let stake_pubkey = solana_sdk::pubkey::new_rand();
+        let stake_lamports = 42;
+        let stake_account =
+            Account::new_ref(stake_lamports, std::mem::size_of::<StakeState>() + 1, &id());
+        let stake_keyed_account = KeyedAccount::new(&stake_pubkey, false, &stake_account);
+
+        assert_eq!(
+            stake_keyed_account.initialize(
+                &Authorized::default(),
+                &Lockup::default(),
+                &Rent {
+                    lamports_per_byte_year: 42,
+                    ..Rent::free()
+                },
+            ),
+            Err(InstructionError::InvalidAccountData)
+        );
+
+        let stake_account =
+            Account::new_ref(stake_lamports, std::mem::size_of::<StakeState>() - 1, &id());
+        let stake_keyed_account = KeyedAccount::new(&stake_pubkey, false, &stake_account);
+
+        assert_eq!(
+            stake_keyed_account.initialize(
+                &Authorized::default(),
+                &Lockup::default(),
+                &Rent {
+                    lamports_per_byte_year: 42,
+                    ..Rent::free()
+                },
+            ),
+            Err(InstructionError::InvalidAccountData)
+        );
+    }
+
     #[test]
     fn test_deactivate() {
         let stake_pubkey = solana_sdk::pubkey::new_rand();