gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't add reviewers to draft PRs (#3780)

Browse Source
This commit is contained in:
Greg Fitzgerald
2019-04-15 15:03:44 -06:00
committed by GitHub
parent 149d809e86
commit 3e1214a871
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
CONTRIBUTING.md
View File

@@ -46,10 +46,17 @@ and longer descriptions detailing what problem it solves and how it solves it.
Draft Pull Requests Draft Pull Requests
--- ---
If you want early feedback on your PR, use GitHub's "Draft Pull Request" mechanism. Draft If you want early feedback on your PR, use GitHub's "Draft Pull Request"
PRs are a convenient way to collaborate with the Solana maintainers without triggering mechanism. Draft PRs are a convenient way to collaborate with the Solana
notifications as you make changes. When you feel your PR is ready for a broader audience, maintainers without triggering notifications as you make changes. When you feel
you can transition your draft PR to a standard PR with the click of a button. your PR is ready for a broader audience, you can transition your draft PR to a
standard PR with the click of a button.
Do not add reviewers to draft PRs. GitHub doesn't automatically clear approvals
when you click "Ready for Review", so a review that meant "I approve of the
direction" suddenly has the appearance of "I approve of these changes." Instead,
add a comment that mentions the usernames that you would like a review from. Ask
explicitly what you would like feedback on.
Rust coding conventions Rust coding conventions
--- ---