increment_cargo_version.sh tune ups (bp #15880) (#15891)

* Disallow version bump with dirty working tree

(cherry picked from commit 853e735edf)

* Ignore `not_paths` for `*.md` files when bumping version

(cherry picked from commit 510760d81b)

* Also ignore `*/node_modules/*` paths when bumping version

(cherry picked from commit 2bf46b789f)

Co-authored-by: Trent Nelson <trent@solana.com>

scripts/increment-cargo-version.sh

@@ -23,6 +23,7 @@ ignores=(
   .cargo
   target
   web3.js/examples
+  node_modules
 )
 
 not_paths=()
@@ -30,10 +31,10 @@ for ignore in "${ignores[@]}"; do
   not_paths+=(-not -path "*/$ignore/*")
 done
 
-# shellcheck disable=2207,SC2068 # Don't want a positional arg if `not-paths` is empty
-Cargo_tomls=($(find . -mindepth 2 -name Cargo.toml ${not_paths[@]}))
 # shellcheck disable=2207
-markdownFiles=($(find . -name "*.md"))
+Cargo_tomls=($(find . -mindepth 2 -name Cargo.toml "${not_paths[@]}"))
+# shellcheck disable=2207
+markdownFiles=($(find . -name "*.md" "${not_paths[@]}"))
 
 # Collect the name of all the internal crates
 crates=()
@@ -105,6 +106,17 @@ check)
   ;;
 esac
 
+# Version bumps should occur in their own commit. Disallow bumping version
+# in dirty working trees. Gate after arg parsing to prevent breaking the
+# `check` subcommand.
+(
+  set +e
+  if ! git diff --exit-code; then
+    echo -e "\nError: Working tree is dirty. Commit or discard changes before bumping version." 1>&2
+    exit 1
+  fi
+)
+
 newVersion="$MAJOR.$MINOR.$PATCH$SPECIAL"
 
 # Update all the Cargo.toml files