diff --git a/programs/bpf_loader/src/syscalls.rs b/programs/bpf_loader/src/syscalls.rs index 958af313bb..21a9772b4d 100644 --- a/programs/bpf_loader/src/syscalls.rs +++ b/programs/bpf_loader/src/syscalls.rs @@ -24,7 +24,7 @@ use solana_sdk::{ message::Message, process_instruction::{stable_log, ComputeMeter, InvokeContext, Logger}, program_error::ProgramError, - pubkey::{Pubkey, PubkeyError}, + pubkey::{Pubkey, PubkeyError, MAX_SEEDS}, }; use std::{ alloc::Layout, @@ -600,6 +600,10 @@ impl<'a> SyscallObject for SyscallCreateProgramAddress<'a> { translate_slice::<&[&u8]>(memory_mapping, seeds_addr, seeds_len, self.loader_id), result ); + if untranslated_seeds.len() > MAX_SEEDS { + *result = Ok(1); + return; + } let seeds = question_mark!( untranslated_seeds .iter() @@ -619,9 +623,7 @@ impl<'a> SyscallObject for SyscallCreateProgramAddress<'a> { result ); - let new_address = match Pubkey::create_program_address(&seeds, program_id) - .map_err(SyscallError::BadSeeds) - { + let new_address = match Pubkey::create_program_address(&seeds, program_id) { Ok(address) => address, Err(_) => { *result = Ok(1); @@ -921,6 +923,9 @@ impl<'a> SyscallInvokeSigned<'a> for SyscallInvokeSignedRust<'a> { signers_seeds_len, self.loader_id, )?; + if signers_seeds.len() > MAX_SEEDS { + return Err(SyscallError::BadSeeds(PubkeyError::MaxSeedLengthExceeded).into()); + } for signer_seeds in signers_seeds.iter() { let untranslated_seeds = translate_slice::<&[u8]>( memory_mapping, @@ -1170,6 +1175,9 @@ impl<'a> SyscallInvokeSigned<'a> for SyscallInvokeSignedC<'a> { signers_seeds_len, self.loader_id, )?; + if signers_seeds.len() > MAX_SEEDS { + return Err(SyscallError::BadSeeds(PubkeyError::MaxSeedLengthExceeded).into()); + } Ok(signers_seeds .iter() .map(|signer_seeds| { diff --git a/sdk/program/src/pubkey.rs b/sdk/program/src/pubkey.rs index 220951e9ec..5e9eeb1f75 100644 --- a/sdk/program/src/pubkey.rs +++ b/sdk/program/src/pubkey.rs @@ -3,8 +3,10 @@ use num_derive::{FromPrimitive, ToPrimitive}; use std::{convert::TryFrom, fmt, mem, str::FromStr}; use thiserror::Error; -/// maximum length of derived pubkey seed +/// maximum length of derived `Pubkey` seed pub const MAX_SEED_LEN: usize = 32; +/// Maximum number of seeds +pub const MAX_SEEDS: usize = 16; #[derive(Error, Debug, Serialize, Clone, PartialEq, FromPrimitive, ToPrimitive)] pub enum PubkeyError { @@ -136,15 +138,21 @@ impl Pubkey { seeds: &[&[u8]], program_id: &Pubkey, ) -> Result { + if seeds.len() > MAX_SEEDS { + return Err(PubkeyError::MaxSeedLengthExceeded); + } + for seed in seeds.iter() { + if seed.len() > MAX_SEED_LEN { + return Err(PubkeyError::MaxSeedLengthExceeded); + } + } + // Perform the calculation inline, calling this from within a program is // not supported #[cfg(not(target_arch = "bpf"))] { let mut hasher = crate::hash::Hasher::default(); for seed in seeds.iter() { - if seed.len() > MAX_SEED_LEN { - return Err(PubkeyError::MaxSeedLengthExceeded); - } hasher.hash(seed); } hasher.hashv(&[program_id.as_ref(), "ProgramDerivedAddress".as_ref()]);