gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rpc-pubsub: reduce metrics/log spam

Browse Source
This commit is contained in:
Trent Nelson 2022-04-14 00:29:45 -06:00 committed by Trent Nelson
parent 97f2eb8e65
commit 50fba01842
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
rpc/src/rpc_subscriptions.rs
View File

@ -178,11 +178,14 @@ pub struct RpcNotification {
pub created_at: Instant, pub created_at: Instant,
} }
const RPC_NOTIFICATIONS_METRICS_SUBMISSION_INTERVAL_MS: Duration = Duration::from_millis(2_000);
struct RecentItems { struct RecentItems {
queue: VecDeque<Arc<String>>, queue: VecDeque<Arc<String>>,
total_bytes: usize, total_bytes: usize,
max_len: usize, max_len: usize,
max_total_bytes: usize, max_total_bytes: usize,
last_metrics_submission: Instant,
} }
impl RecentItems { impl RecentItems {
@ -192,6 +195,7 @@ impl RecentItems {
total_bytes: 0, total_bytes: 0,
max_len, max_len,
max_total_bytes, max_total_bytes,
last_metrics_submission: Instant::now(),
} }
} }
@ -210,11 +214,22 @@ impl RecentItems {
.expect("total bytes underflow"); .expect("total bytes underflow");
} }
datapoint_info!( let now = Instant::now();
"rpc_subscriptions_recent_items", let last_metrics_ago = now.duration_since(self.last_metrics_submission);
("num", self.queue.len(), i64), if last_metrics_ago > RPC_NOTIFICATIONS_METRICS_SUBMISSION_INTERVAL_MS {
("total_bytes", self.total_bytes, i64), datapoint_info!(
); "rpc_subscriptions_recent_items",
("num", self.queue.len(), i64),
("total_bytes", self.total_bytes, i64),
);
self.last_metrics_submission = now;
} else {
trace!(
"rpc_subscriptions_recent_items num={} total_bytes={}",
self.queue.len(),
self.total_bytes,
);
}
} }
} }
@ -469,7 +484,7 @@ struct PubsubNotificationStats {
impl PubsubNotificationStats { impl PubsubNotificationStats {
fn maybe_submit(&mut self) { fn maybe_submit(&mut self) {
const SUBMIT_CADENCE: Duration = Duration::from_secs(2); const SUBMIT_CADENCE: Duration = RPC_NOTIFICATIONS_METRICS_SUBMISSION_INTERVAL_MS;
let elapsed = self.since.as_ref().map(Instant::elapsed); let elapsed = self.since.as_ref().map(Instant::elapsed);
if elapsed.unwrap_or(Duration::MAX) < SUBMIT_CADENCE { if elapsed.unwrap_or(Duration::MAX) < SUBMIT_CADENCE {
return; return;