client changes for TODOs and looping (#1138)

* remove client.sh from snap
* default to ephemeral instead of ~/.config key
* rework CLI for bench-tps
* remote multinode-demo stuff from remote-client.sh
* remove multinode-demo from remote-sanity and localnet-sanity

multinode-demo/client.sh

@@ -9,33 +9,13 @@ usage() {
     echo "$*"
     echo
   fi
-  echo "usage: $0 [network entry point] [extra args]"
+  echo "usage: $0 [extra args]"
   echo
-  echo " Run bench-tps against the specified network"
+  echo " Run bench-tps "
   echo
   echo "   extra args: additional arguments are pass along to solana-bench-tps"
   echo
   exit 1
 }
 
-# This is a little hacky
-if [[ ${1:0:2} != "--" ]]; then
-  if [[ ${2:0:2} != "--" ]]; then
-    read -r _ leader_address shift < <(find_leader "${@:1:2}")
-  else
-    read -r _ leader_address shift < <(find_leader "${@:1:1}")
-  fi
-else
-  read -r _ leader_address shift < <(find_leader)
-fi
-shift "$shift"
-
-
-client_json="$SOLANA_CONFIG_CLIENT_DIR"/client.json
-[[ -r $client_json ]] || $solana_keygen -o "$client_json"
-
-set -x
-$solana_bench_tps \
-    --network "$leader_address" \
-    --keypair "$SOLANA_CONFIG_CLIENT_DIR"/client.json \
-    "$@"
+$solana_bench_tps "$@"