Remove fee-payer guesswork from Message and Transaction (bp #10776) (#10785)

* Remove fee-payer guesswork from Message and Transaction (#10776)

* Make Message::new_with_payer the default constructor

* Remove Transaction::new_[un]signed_instructions

These guess the fee-payer instead of stating it explicitly

(cherry picked from commit 1c498369b5)

# Conflicts:
#	cli/src/nonce.rs
#	core/src/rpc.rs
#	ledger/src/blockstore.rs
#	programs/bpf/tests/programs.rs

* Fix merge

Co-authored-by: Greg Fitzgerald <greg@solana.com>

runtime/src/message_processor.rs

@@ -604,7 +604,7 @@ mod tests {
                 AccountMeta::new(keys[not_owned_index], false),
                 AccountMeta::new(keys[owned_index], false),
             ];
-            let message = Message::new_with_payer(
+            let message = Message::new(
                 &[Instruction::new(program_ids[owned_index], &[0_u8], metas)],
                 None,
             );
@@ -1101,11 +1101,14 @@ mod tests {
             AccountMeta::new(from_pubkey, true),
             AccountMeta::new_readonly(to_pubkey, false),
         ];
-        let message = Message::new(&[Instruction::new(
-            mock_system_program_id,
-            &MockSystemInstruction::Correct,
-            account_metas.clone(),
-        )]);
+        let message = Message::new(
+            &[Instruction::new(
+                mock_system_program_id,
+                &MockSystemInstruction::Correct,
+                account_metas.clone(),
+            )],
+            Some(&from_pubkey),
+        );
 
         let result =
             message_processor.process_message(&message, &loaders, &accounts, &rent_collector, None);
@@ -1113,11 +1116,14 @@ mod tests {
         assert_eq!(accounts[0].borrow().lamports, 100);
         assert_eq!(accounts[1].borrow().lamports, 0);
 
-        let message = Message::new(&[Instruction::new(
-            mock_system_program_id,
-            &MockSystemInstruction::AttemptCredit { lamports: 50 },
-            account_metas.clone(),
-        )]);
+        let message = Message::new(
+            &[Instruction::new(
+                mock_system_program_id,
+                &MockSystemInstruction::AttemptCredit { lamports: 50 },
+                account_metas.clone(),
+            )],
+            Some(&from_pubkey),
+        );
 
         let result =
             message_processor.process_message(&message, &loaders, &accounts, &rent_collector, None);
@@ -1129,11 +1135,14 @@ mod tests {
             ))
         );
 
-        let message = Message::new(&[Instruction::new(
-            mock_system_program_id,
-            &MockSystemInstruction::AttemptDataChange { data: 50 },
-            account_metas,
-        )]);
+        let message = Message::new(
+            &[Instruction::new(
+                mock_system_program_id,
+                &MockSystemInstruction::AttemptDataChange { data: 50 },
+                account_metas,
+            )],
+            Some(&from_pubkey),
+        );
 
         let result =
             message_processor.process_message(&message, &loaders, &accounts, &rent_collector, None);
@@ -1227,11 +1236,14 @@ mod tests {
         ];
 
         // Try to borrow mut the same account
-        let message = Message::new(&[Instruction::new(
-            mock_program_id,
-            &MockSystemInstruction::BorrowFail,
-            account_metas.clone(),
-        )]);
+        let message = Message::new(
+            &[Instruction::new(
+                mock_program_id,
+                &MockSystemInstruction::BorrowFail,
+                account_metas.clone(),
+            )],
+            Some(&from_pubkey),
+        );
         let result =
             message_processor.process_message(&message, &loaders, &accounts, &rent_collector, None);
         assert_eq!(
@@ -1243,24 +1255,30 @@ mod tests {
         );
 
         // Try to borrow mut the same account in a safe way
-        let message = Message::new(&[Instruction::new(
-            mock_program_id,
-            &MockSystemInstruction::MultiBorrowMut,
-            account_metas.clone(),
-        )]);
+        let message = Message::new(
+            &[Instruction::new(
+                mock_program_id,
+                &MockSystemInstruction::MultiBorrowMut,
+                account_metas.clone(),
+            )],
+            Some(&from_pubkey),
+        );
         let result =
             message_processor.process_message(&message, &loaders, &accounts, &rent_collector, None);
         assert_eq!(result, Ok(()));
 
         // Do work on the same account but at different location in keyed_accounts[]
-        let message = Message::new(&[Instruction::new(
-            mock_program_id,
-            &MockSystemInstruction::DoWork {
-                lamports: 10,
-                data: 42,
-            },
-            account_metas,
-        )]);
+        let message = Message::new(
+            &[Instruction::new(
+                mock_program_id,
+                &MockSystemInstruction::DoWork {
+                    lamports: 10,
+                    data: 42,
+                },
+                account_metas,
+            )],
+            Some(&from_pubkey),
+        );
         let result =
             message_processor.process_message(&message, &loaders, &accounts, &rent_collector, None);
         assert_eq!(result, Ok(()));
@@ -1347,7 +1365,7 @@ mod tests {
             &MockInstruction::NoopSuccess,
             metas.clone(),
         );
-        let message = Message::new_with_payer(&[instruction], None);
+        let message = Message::new(&[instruction], None);
         assert_eq!(
             message_processor.process_cross_program_instruction(
                 &message,
@@ -1374,7 +1392,7 @@ mod tests {
 
         for case in cases {
             let instruction = Instruction::new(callee_program_id, &case.0, metas.clone());
-            let message = Message::new_with_payer(&[instruction], None);
+            let message = Message::new(&[instruction], None);
             assert_eq!(
                 message_processor.process_cross_program_instruction(
                     &message,