From 575400c83f67325326449ed103bbb155f2f37cab Mon Sep 17 00:00:00 2001
From: Jack May <jack@solana.com>
Date: Tue, 29 Sep 2020 20:18:28 -0700
Subject: [PATCH] Run tests with features on rather then off (#12567)

---
 runtime/src/accounts.rs          |  4 ++--
 runtime/src/feature_set.rs       | 19 ++++++++++++-------
 runtime/src/message_processor.rs | 16 ++++++++--------
 3 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/runtime/src/accounts.rs b/runtime/src/accounts.rs
index cc7d02bf95..95a03c955c 100644
--- a/runtime/src/accounts.rs
+++ b/runtime/src/accounts.rs
@@ -887,7 +887,7 @@ mod tests {
             &hash_queue,
             error_counters,
             rent_collector,
-            &FeatureSet::default(),
+            &FeatureSet::all_enabled(),
         )
     }
 
@@ -1832,7 +1832,7 @@ mod tests {
             &hash_queue,
             &mut error_counters,
             &rent_collector,
-            &FeatureSet::default(),
+            &FeatureSet::all_enabled(),
         )
     }
 
diff --git a/runtime/src/feature_set.rs b/runtime/src/feature_set.rs
index 5a806b0431..dacb26d68e 100644
--- a/runtime/src/feature_set.rs
+++ b/runtime/src/feature_set.rs
@@ -67,13 +67,6 @@ pub struct FeatureSet {
     pub active: HashSet<Pubkey>,
     pub inactive: HashSet<Pubkey>,
 }
-
-impl FeatureSet {
-    pub fn is_active(&self, feature_id: &Pubkey) -> bool {
-        self.active.contains(feature_id)
-    }
-}
-
 impl Default for FeatureSet {
     fn default() -> Self {
         // All features disabled
@@ -83,3 +76,15 @@ impl Default for FeatureSet {
         }
     }
 }
+impl FeatureSet {
+    pub fn is_active(&self, feature_id: &Pubkey) -> bool {
+        self.active.contains(feature_id)
+    }
+    /// All features enabled, useful for testing
+    pub fn all_enabled() -> Self {
+        Self {
+            active: FEATURE_NAMES.keys().cloned().collect(),
+            inactive: HashSet::new(),
+        }
+    }
+}
diff --git a/runtime/src/message_processor.rs b/runtime/src/message_processor.rs
index 354611ef6d..f35249c4fe 100644
--- a/runtime/src/message_processor.rs
+++ b/runtime/src/message_processor.rs
@@ -789,7 +789,7 @@ mod tests {
             ComputeBudget::default(),
             Rc::new(RefCell::new(Executors::default())),
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
 
         // Check call depth increases and has a limit
@@ -1326,7 +1326,7 @@ mod tests {
             None,
             executors.clone(),
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         assert_eq!(result, Ok(()));
         assert_eq!(accounts[0].borrow().lamports, 100);
@@ -1349,7 +1349,7 @@ mod tests {
             None,
             executors.clone(),
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         assert_eq!(
             result,
@@ -1376,7 +1376,7 @@ mod tests {
             None,
             executors,
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         assert_eq!(
             result,
@@ -1486,7 +1486,7 @@ mod tests {
             None,
             executors.clone(),
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         assert_eq!(
             result,
@@ -1513,7 +1513,7 @@ mod tests {
             None,
             executors.clone(),
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         assert_eq!(result, Ok(()));
 
@@ -1537,7 +1537,7 @@ mod tests {
             None,
             executors,
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         assert_eq!(result, Ok(()));
         assert_eq!(accounts[0].borrow().lamports, 80);
@@ -1614,7 +1614,7 @@ mod tests {
             ComputeBudget::default(),
             Rc::new(RefCell::new(Executors::default())),
             None,
-            Arc::new(FeatureSet::default()),
+            Arc::new(FeatureSet::all_enabled()),
         );
         let metas = vec![
             AccountMeta::new(owned_key, false),