gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable the PubSub vote subscription by default

Browse Source 
The --rpc-pubsub-enable-vote-subscription flag may be used to enable it.
The current vote subscription is problematic because it emits a
notification for *every* vote, so hundreds a second in a real cluster.
Critically it's also missing information about *who* is voting,
rendering all those notifications practically useless.

Until these two issues can be resolved, the vote subscription is not
much more than a potential DoS vector.
This commit is contained in:
Michael Vines
2020-11-14 09:29:51 -08:00
parent 88ae321d3f
commit 5d72e52ad0
6 changed files with 52 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/validator.rs
View File

@ -344,11 +344,12 @@ impl Validator {
let optimistically_confirmed_bank =
OptimisticallyConfirmedBank::locked_from_bank_forks_root(&bank_forks);
let subscriptions = Arc::new(RpcSubscriptions::new(
let subscriptions = Arc::new(RpcSubscriptions::new_with_vote_subscription(
&exit,
bank_forks.clone(),
block_commitment_cache.clone(),
optimistically_confirmed_bank.clone(),
config.pubsub_config.enable_vote_subscription,
));
let (completed_data_sets_sender, completed_data_sets_receiver) =