gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable the PubSub vote subscription by default

Browse Source 
The --rpc-pubsub-enable-vote-subscription flag may be used to enable it.
The current vote subscription is problematic because it emits a
notification for *every* vote, so hundreds a second in a real cluster.
Critically it's also missing information about *who* is voting,
rendering all those notifications practically useless.

Until these two issues can be resolved, the vote subscription is not
much more than a potential DoS vector.
This commit is contained in:
Michael Vines
2020-11-14 09:29:51 -08:00
parent 88ae321d3f
commit 5d72e52ad0
6 changed files with 52 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docs/src/developing/clients/jsonrpc-api.md
View File

@ -2834,7 +2834,7 @@ Result:
{"jsonrpc":"2.0","result":true,"id":1}
```
### Subscription Websocket
## Subscription Websocket
After connecting to the RPC PubSub websocket at `ws://<ADDRESS>/`:
@ -3355,7 +3355,11 @@ Result:
{"jsonrpc": "2.0","result": true,"id": 1}
```
### voteSubscribe
### voteSubscribe - Unstable, disabled by default
**This subscription is unstable and only available if the validator was started
with the `--rpc-pubsub-enable-vote-subscription` flag. The format of this
subscription may change in the future**
Subscribe to receive notification anytime a new vote is observed in gossip.
These votes are pre-consensus therefore there is no guarantee these votes will