gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Report timing info for stakes cache updates from txs (#20856)

Browse Source
This commit is contained in:
Justin Starry
2021-10-22 12:49:02 -04:00
committed by GitHub
parent 1d9c1ccfd2
commit 735016661b
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/progress_map.rs
View File

@ -65,6 +65,11 @@ impl ReplaySlotStats {
("load_us", self.execute_timings.load_us, i64), ("load_us", self.execute_timings.load_us, i64),
("execute_us", self.execute_timings.execute_us, i64), ("execute_us", self.execute_timings.execute_us, i64),
("store_us", self.execute_timings.store_us, i64), ("store_us", self.execute_timings.store_us, i64),
(
"update_stakes_cache_us",
self.execute_timings.update_stakes_cache_us,
i64
),
( (
"total_batches_len", "total_batches_len",
self.execute_timings.total_batches_len, self.execute_timings.total_batches_len,

15
runtime/src/bank.rs
View File

@ -173,6 +173,7 @@ pub struct ExecuteTimings {
pub load_us: u64, pub load_us: u64,
pub execute_us: u64, pub execute_us: u64,
pub store_us: u64, pub store_us: u64,
pub update_stakes_cache_us: u64,
pub total_batches_len: usize, pub total_batches_len: usize,
pub num_execute_batches: u64, pub num_execute_batches: u64,
pub details: ExecuteDetailsTimings, pub details: ExecuteDetailsTimings,
@ -183,6 +184,9 @@ impl ExecuteTimings {
self.load_us = self.load_us.saturating_add(other.load_us); self.load_us = self.load_us.saturating_add(other.load_us);
self.execute_us = self.execute_us.saturating_add(other.execute_us); self.execute_us = self.execute_us.saturating_add(other.execute_us);
self.store_us = self.store_us.saturating_add(other.store_us); self.store_us = self.store_us.saturating_add(other.store_us);
self.update_stakes_cache_us = self
.update_stakes_cache_us
.saturating_add(other.update_stakes_cache_us);
self.total_batches_len = self self.total_batches_len = self
.total_batches_len .total_batches_len
.saturating_add(other.total_batches_len); .saturating_add(other.total_batches_len);
@ -4128,8 +4132,10 @@ impl Bank {
); );
let rent_debits = self.collect_rent(executed, loaded_txs); let rent_debits = self.collect_rent(executed, loaded_txs);
let mut update_stakes_cache_time = Measure::start("update_stakes_cache_time");
let overwritten_vote_accounts = let overwritten_vote_accounts =
self.update_cached_accounts(sanitized_txs, executed, loaded_txs); self.update_stakes_cache(sanitized_txs, executed, loaded_txs);
update_stakes_cache_time.stop();
// once committed there is no way to unroll // once committed there is no way to unroll
write_time.stop(); write_time.stop();
@ -4139,6 +4145,9 @@ impl Bank {
sanitized_txs.len() sanitized_txs.len()
); );
timings.store_us = timings.store_us.saturating_add(write_time.as_us()); timings.store_us = timings.store_us.saturating_add(write_time.as_us());
timings.update_stakes_cache_us = timings
.update_stakes_cache_us
.saturating_add(update_stakes_cache_time.as_us());
self.update_transaction_statuses(sanitized_txs, executed); self.update_transaction_statuses(sanitized_txs, executed);
let fee_collection_results = let fee_collection_results =
self.filter_program_errors_and_collect_fee(sanitized_txs, executed); self.filter_program_errors_and_collect_fee(sanitized_txs, executed);
@ -5656,8 +5665,8 @@ impl Bank {
self.epoch_schedule.get_leader_schedule_epoch(slot) self.epoch_schedule.get_leader_schedule_epoch(slot)
} }
/// a bank-level cache of vote accounts /// a bank-level cache of vote accounts and stake delegation info
fn update_cached_accounts( fn update_stakes_cache(
&self, &self,
txs: &[SanitizedTransaction], txs: &[SanitizedTransaction],
res: &[TransactionExecutionResult], res: &[TransactionExecutionResult],