Add hash_new_rand(), mark Hash::new_rand() as deprecated

sdk/src/hash.rs

@@ -76,6 +76,17 @@ impl FromStr for Hash {
     }
 }
 
+/// New random hash value for tests and benchmarks.
+#[cfg(feature = "everything")]
+pub fn new_rand<R: ?Sized>(rng: &mut R) -> Hash
+where
+    R: rand::Rng,
+{
+    let mut buf = [0u8; HASH_BYTES];
+    rng.fill(&mut buf);
+    Hash::new(&buf)
+}
+
 impl Hash {
     pub fn new(hash_slice: &[u8]) -> Self {
         Hash(<[u8; HASH_BYTES]>::try_from(hash_slice).unwrap())
@@ -90,14 +101,13 @@ impl Hash {
     }
 
     /// New random hash value for tests and benchmarks.
-    #[cfg(feature = "everything")]
+    #[cfg(all(feature = "everything", not(target_arch = "bpf")))]
+    #[deprecated(since = "1.3.9", note = "Please use 'hash::new_rand' instead")]
     pub fn new_rand<R: ?Sized>(rng: &mut R) -> Self
     where
         R: rand::Rng,
     {
-        let mut buf = [0u8; HASH_BYTES];
+        new_rand(rng)
-        rng.fill(&mut buf);
-        Hash::new(&buf)
     }
 }