gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed DuplicateSigs (#3727)

Browse Source 
* Fixed DuplicateSigs by not recording errors in signature cache of bank
This commit is contained in:
carllin
2019-04-11 11:51:34 -07:00
committed by GitHub
parent 8ada4bfd1f
commit 787dc5748a
2 changed files with 90 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
runtime/src/bank.rs
View File

@ -402,19 +402,17 @@ impl Bank {
);
}
}
Err(TransactionError::BlockhashNotFound) => (),
Err(TransactionError::DuplicateSignature) => (),
Err(TransactionError::AccountNotFound) => (),
Err(e) => {
Err(TransactionError::InstructionError(b, e)) => {
if !tx.signatures.is_empty() {
status_cache.insert(
&tx.message().recent_blockhash,
&tx.signatures[0],
self.slot(),
Err(e.clone()),
Err(TransactionError::InstructionError(*b, e.clone())),
);
}
}
Err(_) => (),
}
}
}
@ -1099,11 +1097,9 @@ mod tests {
assert_eq!(bank.get_balance(&key1), 1);
assert_eq!(bank.get_balance(&key2), 0);
assert_eq!(bank.get_signature_status(&t1.signatures[0]), Some(Ok(())));
// TODO: Transactions that fail to pay a fee could be dropped silently
assert_eq!(
bank.get_signature_status(&t2.signatures[0]),
Some(Err(TransactionError::AccountInUse))
);
// TODO: Transactions that fail to pay a fee could be dropped silently.
// Non-instruction errors don't get logged in the signature cache
assert_eq!(bank.get_signature_status(&t2.signatures[0]), None);
}
#[test]