diff --git a/programs/ed25519/src/lib.rs b/programs/ed25519/src/lib.rs index b0496f02cf..7f4dc8b730 100644 --- a/programs/ed25519/src/lib.rs +++ b/programs/ed25519/src/lib.rs @@ -44,7 +44,14 @@ pub mod test { assert!(tx.verify_precompiles(&feature_set).is_ok()); - let index = thread_rng().gen_range(0, instruction.data.len()); + let index = loop { + let index = thread_rng().gen_range(0, instruction.data.len()); + // byte 1 is not used, so this would not cause the verify to fail + if index != 1 { + break index; + } + }; + instruction.data[index] = instruction.data[index].wrapping_add(12); let tx = Transaction::new_signed_with_payer( &[instruction], diff --git a/sdk/src/ed25519_instruction.rs b/sdk/src/ed25519_instruction.rs index 911b31e80b..ae7a3c9395 100644 --- a/sdk/src/ed25519_instruction.rs +++ b/sdk/src/ed25519_instruction.rs @@ -108,6 +108,7 @@ pub fn verify_signatures(data: &[u8], instruction_datas: &[&[u8]]) -> Result<(), let expected_data_size = num_signatures .saturating_mul(SIGNATURE_OFFSETS_SERIALIZED_SIZE) .saturating_add(SIGNATURE_OFFSETS_START); + // We do not check or use the byte at data[1] if data.len() < expected_data_size { return Err(Ed25519Error::InvalidInstructionDataSize); }