gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: PublicKey.toBuffer() now zero pads correctly

Browse Source
This commit is contained in:
Michael Vines
2018-10-23 12:25:02 -07:00
parent 5a42cadefe
commit 96c685eb5d
2 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web3.js/src/publickey.js
View File

@ -69,7 +69,7 @@ export class PublicKey {
} }
const zeroPad = Buffer.alloc(32); const zeroPad = Buffer.alloc(32);
b.copy(zeroPad); b.copy(zeroPad, 32 - b.length);
return zeroPad; return zeroPad;
} }

24
web3.js/test/publickey.test.js
View File

@ -25,15 +25,16 @@ test('equals', () => {
const decimalKey = new PublicKey('1356938545749799165119972480570561420155507632800475359837393562592731987968'); const decimalKey = new PublicKey('1356938545749799165119972480570561420155507632800475359837393562592731987968');
const base56Key = new PublicKey('CiDwVBFgWV9E5MvXWoLgnEgn2hK7rJikbvfWavzAQz3'); const base56Key = new PublicKey('CiDwVBFgWV9E5MvXWoLgnEgn2hK7rJikbvfWavzAQz3');
expect(arrayKey.equals(hexKey)).toBeTruthy(); expect(arrayKey.equals(hexKey)).toBe(true);
expect(arrayKey.equals(decimalKey)).toBeTruthy(); expect(arrayKey.equals(decimalKey)).toBe(true);
expect(arrayKey.equals(base56Key)).toBeTruthy(); expect(arrayKey.equals(base56Key)).toBe(true);
}); });
test('isPublicKey', () => { test('isPublicKey', () => {
const key = new PublicKey('0x100000000000000000000000000000000000000000000000000000000000000'); const key = new PublicKey('0x100000000000000000000000000000000000000000000000000000000000000');
expect(PublicKey.isPublicKey(key)).toBeTruthy(); expect(PublicKey.isPublicKey(key)).toBe(true);
expect(PublicKey.isPublicKey({})).toBeFalsy(); expect(PublicKey.isPublicKey({})).toBe(false);
}); });
test('toBase58', () => { test('toBase58', () => {
@ -42,8 +43,8 @@ test('toBase58', () => {
expect(key.toString()).toBe('CiDwVBFgWV9E5MvXWoLgnEgn2hK7rJikbvfWavzAQz3'); expect(key.toString()).toBe('CiDwVBFgWV9E5MvXWoLgnEgn2hK7rJikbvfWavzAQz3');
const key2 = new PublicKey('123456789'); const key2 = new PublicKey('123456789');
expect(key2.toBase58()).toBe('Vj3WURvtMv1mii1vhTqLhcSwVWDRs2E135KtTYUXtTq'); expect(key2.toBase58()).toBe('1111111111111111111111111111BukQL');
expect(key2.toString()).toBe('Vj3WURvtMv1mii1vhTqLhcSwVWDRs2E135KtTYUXtTq'); expect(key2.toString()).toBe('1111111111111111111111111111BukQL');
}); });
test('toBuffer', () => { test('toBuffer', () => {
@ -56,3 +57,12 @@ test('toBuffer', () => {
expect(key2.toBase58()).toBe('11111111111111111111111111111111'); expect(key2.toBase58()).toBe('11111111111111111111111111111111');
}); });
test('equals (II)', () => {
const key1 = new PublicKey([
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1,
]);
const key2 = new PublicKey(key1.toBuffer());
expect(key1.equals(key2)).toBe(true);
});