RPC: Allow the sendTransaction preflight commitment level to be configured (bp #11792) (#11793)

* Allow the sendTransaction preflight commitment level to be configured

(cherry picked from commit b660704faa)

# Conflicts:
#	cli/src/cli.rs
#	core/src/rpc.rs

* rebase

Co-authored-by: Michael Vines <mvines@gmail.com>

cli/src/cli.rs

@@ -1290,6 +1290,7 @@ fn send_and_confirm_transactions_with_spinner<T: Signers>(
                     &transaction,
                     RpcSendTransactionConfig {
                         skip_preflight: true,
+                        ..RpcSendTransactionConfig::default()
                     },
                 )
                 .ok();
@@ -1442,6 +1443,7 @@ fn process_deploy(
             &finalize_tx,
             RpcSendTransactionConfig {
                 skip_preflight: true,
+                ..RpcSendTransactionConfig::default()
             },
         )
         .map_err(|e| {

client/src/rpc_config.rs

@@ -12,12 +12,14 @@ pub struct RpcSignatureStatusConfig {
 #[serde(rename_all = "camelCase")]
 pub struct RpcSendTransactionConfig {
     pub skip_preflight: bool,
+    pub preflight_commitment: Option<CommitmentConfig>,
 }
 
 #[derive(Debug, Default, Clone, PartialEq, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct RpcSimulateTransactionConfig {
     pub sig_verify: bool,
+    pub commitment: Option<CommitmentConfig>,
 }
 
 #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]

core/src/rpc.rs

@@ -2101,7 +2101,9 @@ impl RpcSol for RpcSolImpl {
                 .into());
             }
 
-            if let (Err(err), _log_output) = run_transaction_simulation(&bank, transaction.clone())
+            let preflight_bank = &*meta.bank(config.preflight_commitment)?;
+            if let (Err(err), _log_output) =
+                run_transaction_simulation(&preflight_bank, transaction.clone())
             {
                 // Note: it's possible that the transaction simulation failed but the actual
                 // transaction would succeed, such as when a transaction depends on an earlier
@@ -2134,7 +2136,7 @@ impl RpcSol for RpcSolImpl {
             Ok(())
         };
 
-        let bank = &*meta.bank(None)?;
+        let bank = &*meta.bank(config.commitment)?;
         let logs = if result.is_ok() {
             let sim_result = run_transaction_simulation(&bank, transaction);
             result = sim_result.0;

docs/src/apps/jsonrpc-api.md

@@ -1353,6 +1353,7 @@ Before submitting, the following preflight checks are performed:
 - `<string>` - fully-signed Transaction, as base-58 encoded string
 - `<object>` - (optional) Configuration object containing the following field:
   - `skipPreflight: <bool>` - if true, skip the preflight transaction checks (default: false)
+  - `preflightCommitment: <object>` - (optional) [Commitment](jsonrpc-api.md#configuring-state-commitment) level to use for preflight (default: max).
 
 #### Results:
 
@@ -1377,6 +1378,7 @@ Simulate sending a transaction
 - `<string>` - Transaction, as base-58 encoded string. The transaction must have a valid blockhash, but is not required to be signed.
 - `<object>` - (optional) Configuration object containing the following field:
   - `sigVerify: <bool>` - if true the transaction signatures will be verified (default: false)
+  - `commitment: <object>` - (optional) [Commitment](jsonrpc-api.md#configuring-state-commitment) level to simulate the transaction at (default: max).
 
 #### Results:
 

stake-monitor/src/lib.rs

@@ -493,6 +493,7 @@ mod test {
                 ),
                 RpcSendTransactionConfig {
                     skip_preflight: true,
+                    ..RpcSendTransactionConfig::default()
                 },
             )
             .unwrap();
@@ -548,6 +549,7 @@ mod test {
                 ),
                 RpcSendTransactionConfig {
                     skip_preflight: true,
+                    ..RpcSendTransactionConfig::default()
                 },
             )
             .unwrap();
@@ -593,6 +595,7 @@ mod test {
                 ),
                 RpcSendTransactionConfig {
                     skip_preflight: true,
+                    ..RpcSendTransactionConfig::default()
                 },
             )
             .unwrap();
@@ -631,6 +634,7 @@ mod test {
                 ),
                 RpcSendTransactionConfig {
                     skip_preflight: true,
+                    ..RpcSendTransactionConfig::default()
                 },
             )
             .unwrap();

tokens/src/thin_client.rs

@@ -35,6 +35,7 @@ impl Client for RpcClient {
             &transaction,
             RpcSendTransactionConfig {
                 skip_preflight: true,
+                ..RpcSendTransactionConfig::default()
             },
         )
         .map_err(|e| TransportError::Custom(e.to_string()))