Move gossip modules into solana-gossip crate (#17352)

* Move gossip modules to solana-gossip

* Update Protocol abi digest due to move

* Move gossip benches and hook up CI

* Remove unneeded Result entries

* Single use statements

core/benches/banking_stage.rs

@@ -8,9 +8,9 @@ use log::*;
 use rand::{thread_rng, Rng};
 use rayon::prelude::*;
 use solana_core::banking_stage::{create_test_recorder, BankingStage, BankingStageStats};
-use solana_core::cluster_info::ClusterInfo;
-use solana_core::cluster_info::Node;
 use solana_core::poh_recorder::WorkingBankEntry;
+use solana_gossip::cluster_info::ClusterInfo;
+use solana_gossip::cluster_info::Node;
 use solana_ledger::blockstore_processor::process_entries;
 use solana_ledger::entry::{next_hash, Entry};
 use solana_ledger::genesis_utils::{create_genesis_config, GenesisConfigInfo};

core/benches/cluster_info.rs

@@ -5,8 +5,8 @@ extern crate test;
 use rand::{thread_rng, Rng};
 use solana_core::broadcast_stage::broadcast_metrics::TransmitShredsStats;
 use solana_core::broadcast_stage::{broadcast_shreds, get_broadcast_peers};
-use solana_core::cluster_info::{ClusterInfo, Node};
-use solana_core::contact_info::ContactInfo;
+use solana_gossip::cluster_info::{ClusterInfo, Node};
+use solana_gossip::contact_info::ContactInfo;
 use solana_ledger::shred::Shred;
 use solana_sdk::pubkey;
 use solana_sdk::timing::timestamp;

core/benches/crds.rs

@@ -1,31 +0,0 @@
-#![feature(test)]
-
-extern crate test;
-
-use rand::{thread_rng, Rng};
-use rayon::ThreadPoolBuilder;
-use solana_core::crds::Crds;
-use solana_core::crds_gossip_pull::CRDS_GOSSIP_PULL_CRDS_TIMEOUT_MS;
-use solana_core::crds_value::CrdsValue;
-use solana_sdk::pubkey::Pubkey;
-use std::collections::HashMap;
-use test::Bencher;
-
-#[bench]
-fn bench_find_old_labels(bencher: &mut Bencher) {
-    let thread_pool = ThreadPoolBuilder::new().build().unwrap();
-    let mut rng = thread_rng();
-    let mut crds = Crds::default();
-    let now = CRDS_GOSSIP_PULL_CRDS_TIMEOUT_MS + CRDS_GOSSIP_PULL_CRDS_TIMEOUT_MS / 1000;
-    std::iter::repeat_with(|| (CrdsValue::new_rand(&mut rng, None), rng.gen_range(0, now)))
-        .take(50_000)
-        .for_each(|(v, ts)| assert!(crds.insert(v, ts).is_ok()));
-    let mut timeouts = HashMap::new();
-    timeouts.insert(Pubkey::default(), CRDS_GOSSIP_PULL_CRDS_TIMEOUT_MS);
-    bencher.iter(|| {
-        let out = crds.find_old_labels(&thread_pool, now, &timeouts);
-        assert!(out.len() > 10);
-        assert!(out.len() < 250);
-        out
-    });
-}

core/benches/crds_gossip_pull.rs

@@ -1,48 +0,0 @@
-#![feature(test)]
-
-extern crate test;
-
-use rand::{thread_rng, Rng};
-use rayon::ThreadPoolBuilder;
-use solana_core::cluster_info::MAX_BLOOM_SIZE;
-use solana_core::crds::Crds;
-use solana_core::crds_gossip_pull::{CrdsFilter, CrdsGossipPull};
-use solana_core::crds_value::CrdsValue;
-use solana_sdk::hash;
-use test::Bencher;
-
-#[bench]
-fn bench_hash_as_u64(bencher: &mut Bencher) {
-    let mut rng = thread_rng();
-    let hashes: Vec<_> = std::iter::repeat_with(|| hash::new_rand(&mut rng))
-        .take(1000)
-        .collect();
-    bencher.iter(|| {
-        hashes
-            .iter()
-            .map(CrdsFilter::hash_as_u64)
-            .collect::<Vec<_>>()
-    });
-}
-
-#[bench]
-fn bench_build_crds_filters(bencher: &mut Bencher) {
-    let thread_pool = ThreadPoolBuilder::new().build().unwrap();
-    let mut rng = thread_rng();
-    let crds_gossip_pull = CrdsGossipPull::default();
-    let mut crds = Crds::default();
-    let mut num_inserts = 0;
-    for _ in 0..90_000 {
-        if crds
-            .insert(CrdsValue::new_rand(&mut rng, None), rng.gen())
-            .is_ok()
-        {
-            num_inserts += 1;
-        }
-    }
-    assert_eq!(num_inserts, 90_000);
-    bencher.iter(|| {
-        let filters = crds_gossip_pull.build_crds_filters(&thread_pool, &crds, MAX_BLOOM_SIZE);
-        assert_eq!(filters.len(), 128);
-    });
-}

core/benches/crds_shards.rs

@@ -1,73 +0,0 @@
-#![feature(test)]
-
-extern crate test;
-
-use rand::{thread_rng, Rng};
-use solana_core::{
-    crds::{Crds, VersionedCrdsValue},
-    crds_shards::CrdsShards,
-    crds_value::CrdsValue,
-};
-use solana_sdk::timing::timestamp;
-use std::iter::repeat_with;
-use test::Bencher;
-
-const CRDS_SHARDS_BITS: u32 = 8;
-
-fn new_test_crds_value<R: Rng>(rng: &mut R) -> VersionedCrdsValue {
-    let value = CrdsValue::new_rand(rng, None);
-    let label = value.label();
-    let mut crds = Crds::default();
-    crds.insert(value, timestamp()).unwrap();
-    crds.get(&label).cloned().unwrap()
-}
-
-fn bench_crds_shards_find(bencher: &mut Bencher, num_values: usize, mask_bits: u32) {
-    let mut rng = thread_rng();
-    let values: Vec<_> = repeat_with(|| new_test_crds_value(&mut rng))
-        .take(num_values)
-        .collect();
-    let mut shards = CrdsShards::new(CRDS_SHARDS_BITS);
-    for (index, value) in values.iter().enumerate() {
-        assert!(shards.insert(index, value));
-    }
-    bencher.iter(|| {
-        let mask = rng.gen();
-        let _hits = shards.find(mask, mask_bits).count();
-    });
-}
-
-#[bench]
-fn bench_crds_shards_find_0(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 0);
-}
-
-#[bench]
-fn bench_crds_shards_find_1(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 1);
-}
-
-#[bench]
-fn bench_crds_shards_find_3(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 3);
-}
-
-#[bench]
-fn bench_crds_shards_find_5(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 5);
-}
-
-#[bench]
-fn bench_crds_shards_find_7(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 7);
-}
-
-#[bench]
-fn bench_crds_shards_find_8(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 8);
-}
-
-#[bench]
-fn bench_crds_shards_find_9(bencher: &mut Bencher) {
-    bench_crds_shards_find(bencher, 100_000, 9);
-}

core/benches/retransmit_stage.rs

@@ -4,9 +4,9 @@ extern crate solana_core;
 extern crate test;
 
 use log::*;
-use solana_core::cluster_info::{ClusterInfo, Node};
-use solana_core::contact_info::ContactInfo;
 use solana_core::retransmit_stage::retransmitter;
+use solana_gossip::cluster_info::{ClusterInfo, Node};
+use solana_gossip::contact_info::ContactInfo;
 use solana_ledger::entry::Entry;
 use solana_ledger::genesis_utils::{create_genesis_config, GenesisConfigInfo};
 use solana_ledger::leader_schedule_cache::LeaderScheduleCache;