gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a bug in input deserialization in the C SDK (#17217) (#17249)

Browse Source 
When the input contains more accounts than the user has requested to be deserialized, and one of the excess ones is a dup, the input pointer is not adjusted correctly.

Compare the lines added by this commit to line 401: "input += 7; // padding". Since the input data layout does not depend on the number of accounts the user wants to deserialize, this adjustment by 7 bytes must happen in both branches.

(cherry picked from commit e02b4e1192)

Co-authored-by: Christian Machacek <39452430+machacekch@users.noreply.github.com>
This commit is contained in:
mergify[bot]
2021-05-15 00:10:02 +00:00
committed by GitHub
parent e41460d500
commit 9e42883d4b
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/bpf/c/inc/solana_sdk.h
View File

@ -345,6 +345,8 @@ static bool sol_deserialize(
input += MAX_PERMITTED_DATA_INCREASE; input += MAX_PERMITTED_DATA_INCREASE;
input = (uint8_t*)(((uint64_t)input + 8 - 1) & ~(8 - 1)); // padding input = (uint8_t*)(((uint64_t)input + 8 - 1) & ~(8 - 1)); // padding
input += sizeof(uint64_t); input += sizeof(uint64_t);
} else {
input += 7; // padding
} }
continue; continue;
} }