gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove notifier module duplication (#10051)

Browse Source
This commit is contained in:
Michael Vines
2020-05-14 17:32:08 -07:00
committed by GitHub
parent 40b7c11262
commit 9ef9969d29
15 changed files with 114 additions and 160 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ramp-tps/Cargo.toml
View File

@@ -21,6 +21,7 @@ solana-client = { path = "../client", version = "1.2.0" }
solana-logger = { path = "../logger", version = "1.2.0" }
solana-metrics = { path = "../metrics", version = "1.2.0" }
solana-net-utils = { path = "../net-utils", version = "1.2.0" }
solana-notifier = { path = "../notifier", version = "1.2.0" }
solana-sdk = { path = "../sdk", version = "1.2.0" }
solana-stake-program = { path = "../programs/stake", version = "1.2.0" }
tar = "0.4.26"

18
ramp-tps/src/main.rs
View File

@@ -1,6 +1,5 @@
//! Ramp up TPS for Tour de SOL until all validators drop out
mod notifier;
mod results;
mod stake;
mod tps;
@@ -54,7 +53,7 @@ fn gift_for_round(tps_round: u32, initial_balance: u64) -> u64 {
fn main() {
solana_logger::setup_with_default("solana=debug");
solana_metrics::set_panic_hook("ramp-tps");
let mut notifier = notifier::Notifier::new();
let mut notifier = solana_notifier::Notifier::default();
let matches = App::new(crate_name!())
.about(crate_description!())
@@ -199,7 +198,7 @@ fn main() {
let _ = fs::remove_dir_all(&tmp_ledger_path);
fs::create_dir_all(&tmp_ledger_path).expect("failed to create temp ledger path");
notifier.notify("Hi!");
notifier.send("Hi!");
datapoint_info!("ramp-tps", ("event", "boot", String),);
let entrypoint_str = matches.value_of("entrypoint").unwrap();
@@ -219,7 +218,7 @@ fn main() {
debug!("First normal slot: {}", first_normal_slot);
let sleep_slots = first_normal_slot.saturating_sub(current_slot);
if sleep_slots > 0 {
notifier.notify(&format!(
notifier.send(&format!(
"Waiting for warm-up epochs to complete (epoch {})",
epoch_schedule.first_normal_epoch
));
@@ -291,7 +290,7 @@ fn main() {
let mut tps_sampler = tps::Sampler::new(&entrypoint_addr);
loop {
notifier.notify(&format!("Round {}!", tps_round));
notifier.send(&format!("Round {}!", tps_round));
let tx_count = tx_count_for_round(tps_round, tx_count_baseline, tx_count_increment);
datapoint_info!(
"ramp-tps",
@@ -328,7 +327,7 @@ fn main() {
("validators", starting_validators.len(), i64)
);
notifier.buffer(format!(
notifier.send(&format!(
"There are {} validators present:",
starting_validators.len()
));
@@ -338,11 +337,10 @@ fn main() {
.map(|node_pubkey| format!("* {}", pubkey_to_keybase(&node_pubkey)))
.collect();
validators.sort();
notifier.buffer_vec(validators);
notifier.flush();
notifier.send(&validators.join("\n"));
let client_tx_count = tx_count / NUM_BENCH_CLIENTS as u64;
notifier.notify(&format!(
notifier.send(&format!(
"Starting transactions for {} minutes (batch size={})",
round_minutes, tx_count,
));
@@ -393,7 +391,7 @@ fn main() {
("round", tps_round, i64),
);
notifier.notify("Transactions stopped");
notifier.send("Transactions stopped");
tps_sampler.report_results(&notifier);
let remaining_validators = voters::fetch_active_validators(&rpc_client);

92
ramp-tps/src/notifier.rs
View File

@@ -1,92 +0,0 @@
use log::*;
use reqwest::{blocking::Client, StatusCode};
use serde_json::json;
use std::{env, thread::sleep, time::Duration};
/// For each notification
/// 1) Log an info level message
/// 2) Notify Slack channel if Slack is configured
/// 3) Notify Discord channel if Discord is configured
pub struct Notifier {
buffer: Vec<String>,
client: Client,
discord_webhook: Option<String>,
slack_webhook: Option<String>,
}
impl Notifier {
pub fn new() -> Self {
let discord_webhook = env::var("DISCORD_WEBHOOK")
.map_err(|_| {
warn!("Discord notifications disabled");
})
.ok();
let slack_webhook = env::var("SLACK_WEBHOOK")
.map_err(|_| {
warn!("Slack notifications disabled");
})
.ok();
Notifier {
buffer: Vec::new(),
client: Client::new(),
discord_webhook,
slack_webhook,
}
}
fn send(&self, msg: &str) {
if let Some(webhook) = &self.discord_webhook {
for line in msg.split('\n') {
// Discord rate limiting is aggressive, limit to 1 message a second to keep
// it from getting mad at us...
sleep(Duration::from_millis(1000));
info!("Sending {}", line);
let data = json!({ "content": line });
loop {
let response = self.client.post(webhook).json(&data).send();
if let Err(err) = response {
warn!("Failed to send Discord message: \"{}\": {:?}", line, err);
break;
} else if let Ok(response) = response {
info!("response status: {}", response.status());
if response.status() == StatusCode::TOO_MANY_REQUESTS {
warn!("rate limited!...");
warn!("response text: {:?}", response.text());
std::thread::sleep(Duration::from_secs(2));
} else {
break;
}
}
}
}
}
if let Some(webhook) = &self.slack_webhook {
let data = json!({ "text": msg });
if let Err(err) = self.client.post(webhook).json(&data).send() {
warn!("Failed to send Slack message: {:?}", err);
}
}
}
pub fn buffer(&mut self, msg: String) {
self.buffer.push(msg);
}
pub fn buffer_vec(&mut self, mut msgs: Vec<String>) {
self.buffer.append(&mut msgs);
}
pub fn flush(&mut self) {
self.notify(&self.buffer.join("\n"));
self.buffer.clear();
}
pub fn notify(&self, msg: &str) {
info!("{}", msg);
self.send(msg);
}
}

8
ramp-tps/src/stake.rs
View File

@@ -1,4 +1,4 @@
use crate::{notifier, utils};
use crate::utils;
use log::*;
use solana_client::{rpc_client::RpcClient, rpc_response::RpcEpochInfo};
use solana_sdk::{
@@ -64,11 +64,11 @@ pub fn wait_for_warm_up(
rpc_client: &RpcClient,
stake_config: &StakeConfig,
genesis_config: &GenesisConfig,
notifier: &notifier::Notifier,
notifier: &solana_notifier::Notifier,
) {
// Sleep until activation_epoch has finished
if epoch_info.epoch <= activation_epoch {
notifier.notify(&format!(
notifier.send(&format!(
"Waiting until epoch {} is finished...",
activation_epoch
));
@@ -105,7 +105,7 @@ pub fn wait_for_warm_up(
let warm_up_epochs = calculate_stake_warmup(stake_entry, stake_config);
let stake_warmed_up_epoch = latest_epoch + warm_up_epochs;
if stake_warmed_up_epoch > current_epoch {
notifier.notify(&format!(
notifier.send(&format!(
"Waiting until epoch {} for stake to warmup (current epoch is {})...",
stake_warmed_up_epoch, current_epoch
));

4
ramp-tps/src/tps.rs
View File

@@ -1,7 +1,7 @@
use crate::notifier::Notifier;
use log::*;
use solana_client::perf_utils::{sample_txs, SampleStats};
use solana_client::thin_client::ThinClient;
use solana_notifier::Notifier;
use solana_sdk::timing::duration_as_s;
use std::{
net::SocketAddr,
@@ -64,7 +64,7 @@ impl Sampler {
pub fn report_results(&self, notifier: &Notifier) {
let SampleStats { tps, elapsed, txs } = self.maxes.read().unwrap()[0].1;
let avg_tps = txs as f32 / duration_as_s(&elapsed);
notifier.notify(&format!(
notifier.send(&format!(
"Highest TPS: {:.0}, Average TPS: {:.0}",
tps, avg_tps
));

6
ramp-tps/src/utils.rs
View File

@@ -1,8 +1,8 @@
use crate::notifier::Notifier;
use bzip2::bufread::BzDecoder;
use log::*;
use solana_client::rpc_client::RpcClient;
use solana_net_utils::parse_host;
use solana_notifier::Notifier;
use solana_sdk::{
clock::{Epoch, Slot},
genesis_config::GenesisConfig,
@@ -89,8 +89,8 @@ pub fn is_host(string: String) -> Result<(), String> {
Ok(())
}
pub fn bail(notifier: &crate::notifier::Notifier, msg: &str) -> ! {
notifier.notify(msg);
pub fn bail(notifier: &Notifier, msg: &str) -> ! {
notifier.send(msg);
sleep(Duration::from_secs(30)); // Wait for notifications to send
std::process::exit(1);
}

20
ramp-tps/src/voters.rs
View File

@@ -1,7 +1,7 @@
use crate::notifier::Notifier;
use crate::utils;
use log::*;
use solana_client::{client_error::Result as ClientResult, rpc_client::RpcClient};
use solana_notifier::Notifier;
use solana_sdk::{
clock::Slot,
epoch_schedule::EpochSchedule,
@@ -183,7 +183,7 @@ pub fn announce_results(
) {
let buffer_records = |keys: Vec<&Pubkey>, notifier: &mut Notifier| {
if keys.is_empty() {
notifier.buffer("* None".to_string());
notifier.send("* None");
return;
}
@@ -199,7 +199,7 @@ pub fn announce_results(
}
}
validators.sort();
notifier.buffer_vec(validators);
notifier.send(&validators.join("\n"));
};
let healthy: Vec<_> = remaining_validators
@@ -217,14 +217,12 @@ pub fn announce_results(
.filter(|k| !remaining_validators.contains_key(k))
.collect();
notifier.buffer("Healthy Validators:".to_string());
notifier.send("Healthy Validators:");
buffer_records(healthy, notifier);
notifier.buffer("Unhealthy Validators:".to_string());
notifier.send("Unhealthy Validators:");
buffer_records(unhealthy, notifier);
notifier.buffer("Inactive Validators:".to_string());
notifier.send("Inactive Validators:");
buffer_records(inactive, notifier);
notifier.flush();
}
/// Award stake to the surviving validators by delegating stake to their vote account
@@ -235,10 +233,12 @@ pub fn award_stake(
sol_gift: u64,
notifier: &mut Notifier,
) {
let mut buffer = vec![];
for (node_pubkey, vote_account_pubkey) in voters {
info!("Delegate {} SOL to {}", sol_gift, node_pubkey);
delegate_stake(rpc_client, faucet_keypair, vote_account_pubkey, sol_gift);
notifier.buffer(format!("Delegated {} SOL to {}", sol_gift, node_pubkey));
buffer.push(format!("Delegated {} SOL to {}", sol_gift, node_pubkey));
}
notifier.flush();
notifier.send(&buffer.join("\n"));
}