From a4cec5c189940bb7d298b3f958527945311c432f Mon Sep 17 00:00:00 2001 From: Michael Vines Date: Sat, 12 Sep 2020 23:24:45 -0700 Subject: [PATCH] chore: remove unnecessary if condition --- web3.js/src/transaction.js | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/web3.js/src/transaction.js b/web3.js/src/transaction.js index 3ea3d289ef..3d53946a29 100644 --- a/web3.js/src/transaction.js +++ b/web3.js/src/transaction.js @@ -501,23 +501,17 @@ export class Transaction { * Serialize the Transaction in the wire format. */ serialize(config?: SerializeConfig): Buffer { - const {signatures} = this; - const {requireAllSignatures, verifySignatures} = Object.assign( {requireAllSignatures: true, verifySignatures: true}, config, ); - if (requireAllSignatures && signatures.length === 0) { - throw new Error('Transaction has not been signed'); - } - const signData = this.serializeMessage(); if ( verifySignatures && !this._verifySignatures(signData, requireAllSignatures) ) { - throw new Error('Transaction has not been signed correctly'); + throw new Error('Signature verification failed'); } return this._serialize(signData);