RPC: use finalized as default pubsub commitment level (#16659)

* RPC: use finalized as default pubsub commitment level

* update docs

* Fix tests
This commit is contained in:
Justin Starry
2021-04-20 16:19:54 +08:00
committed by GitHub
parent c8b474cd0b
commit a7e65c0034
3 changed files with 20 additions and 12 deletions

View File

@ -630,9 +630,7 @@ impl RpcSubscriptions {
subscriber: Subscriber<Response<UiAccount>>,
) {
let config = config.unwrap_or_default();
let commitment = config
.commitment
.unwrap_or_else(CommitmentConfig::confirmed);
let commitment = config.commitment.unwrap_or_default();
let slot = if commitment.is_finalized() {
self.block_commitment_cache
@ -703,10 +701,7 @@ impl RpcSubscriptions {
subscriber: Subscriber<Response<RpcKeyedAccount>>,
) {
let config = config.unwrap_or_default();
let commitment = config
.account_config
.commitment
.unwrap_or_else(CommitmentConfig::confirmed);
let commitment = config.account_config.commitment.unwrap_or_default();
let mut subscriptions = if commitment.is_confirmed() {
self.subscriptions
@ -753,7 +748,7 @@ impl RpcSubscriptions {
sub_id: SubscriptionId,
subscriber: Subscriber<Response<RpcLogsResponse>>,
) {
let commitment = commitment.unwrap_or_else(CommitmentConfig::confirmed);
let commitment = commitment.unwrap_or_default();
{
let mut subscriptions = if commitment.is_confirmed() {
@ -864,7 +859,7 @@ impl RpcSubscriptions {
.map(|config| (config.commitment, config.enable_received_notification))
.unwrap_or_default();
let commitment = commitment.unwrap_or_else(CommitmentConfig::confirmed);
let commitment = commitment.unwrap_or_default();
let mut subscriptions = if commitment.is_confirmed() {
self.subscriptions