rpc-sts: dedupe before initial send (#22855)

(cherry picked from commit 9f1f7aff2b)

Co-authored-by: Trent Nelson <trent@solana.com>
This commit is contained in:
mergify[bot]
2022-02-01 01:26:03 +00:00
committed by GitHub
parent ac36954af0
commit add26be71b

View File

@ -10,7 +10,7 @@ use {
signature::Signature, signature::Signature,
}, },
std::{ std::{
collections::HashMap, collections::hash_map::{Entry, HashMap},
net::{SocketAddr, UdpSocket}, net::{SocketAddr, UdpSocket},
sync::{ sync::{
mpsc::{Receiver, RecvTimeoutError}, mpsc::{Receiver, RecvTimeoutError},
@ -191,6 +191,9 @@ impl SendTransactionService {
Err(RecvTimeoutError::Timeout) => {} Err(RecvTimeoutError::Timeout) => {}
Ok(transaction_info) => { Ok(transaction_info) => {
inc_new_counter_info!("send_transaction_service-recv-tx", 1); inc_new_counter_info!("send_transaction_service-recv-tx", 1);
let transactions_len = transactions.len();
let entry = transactions.entry(transaction_info.signature);
if let Entry::Vacant(_) = entry {
let addresses = leader_info.as_ref().map(|leader_info| { let addresses = leader_info.as_ref().map(|leader_info| {
leader_info.get_leader_tpus(config.leader_forward_count) leader_info.get_leader_tpus(config.leader_forward_count)
}); });
@ -210,12 +213,15 @@ impl SendTransactionService {
&transaction_info.wire_transaction, &transaction_info.wire_transaction,
); );
} }
if transactions.len() < MAX_TRANSACTION_QUEUE_SIZE { if transactions_len < MAX_TRANSACTION_QUEUE_SIZE {
inc_new_counter_info!("send_transaction_service-insert-tx", 1); inc_new_counter_info!("send_transaction_service-insert-tx", 1);
transactions.insert(transaction_info.signature, transaction_info); entry.or_insert(transaction_info);
} else { } else {
datapoint_warn!("send_transaction_service-queue-overflow"); datapoint_warn!("send_transaction_service-queue-overflow");
} }
} else {
inc_new_counter_info!("send_transaction_service-recv-duplicate", 1);
}
} }
} }