check rust programs (#4688)

ci/buildkite.yml

@@ -2,7 +2,7 @@ steps:
   - command: "ci/shellcheck.sh"
     name: "shellcheck"
     timeout_in_minutes: 5
-  - command: ". ci/rust-version.sh; ci/docker-run.sh $$rust_stable_docker_image ci/test-checks.sh"
+  - command: ". ci/rust-version.sh; ci/docker-run.sh $$rust_nightly_docker_image ci/test-checks.sh"
     name: "checks"
     timeout_in_minutes: 15
   - wait

ci/docker-rust-nightly/Dockerfile

@@ -3,6 +3,7 @@ ARG date
 
 RUN set -x \
  && rustup install nightly-$date \
+ && rustup component add clippy --toolchain=nightly-$date \
  && rustup show \
  && rustc --version \
  && cargo --version \

ci/docker-rust-nightly/README.md

@@ -15,12 +15,12 @@ To update the pinned version:
 1. Run `ci/docker-rust-nightly/build.sh` to rebuild the nightly image locally,
    or potentially `ci/docker-rust-nightly/build.sh YYYY-MM-DD` if there's a
    specific YYYY-MM-DD that is desired (default is today's build).
+1. Update `ci/rust-version.sh` to reflect the new nightly `YYY-MM-DD`
 1. Run `SOLANA_DOCKER_RUN_NOSETUID=1 ci/docker-run.sh --nopull solanalabs/rust-nightly:YYYY-MM-DD ci/test-coverage.sh`
    to confirm the new nightly image builds.  Fix any issues as needed
 1. Run `docker login` to enable pushing images to Docker Hub, if you're authorized.
 1. Run `CI=true ci/docker-rust-nightly/build.sh YYYY-MM-DD` to push the new nightly image to dockerhub.com.
-1. Modify the `solanalabs/rust-nightly:YYYY-MM-DD` reference in `ci/rust-version.sh` from the previous to
-   new *YYYY-MM-DD* value, send a PR with this change and any codebase adjustments needed.
+1. Send a PR with the `ci/rust-version.sh` change and any codebase adjustments needed.
 
 ## Troubleshooting
 

ci/nits.sh

@@ -23,11 +23,13 @@ declare print_free_tree=(
   'metrics/src'
   'netutil/src'
   'runtime/src'
+  'sdk/bpf/rust/rust-utils'
   'sdk/src'
-  'programs/vote_api/src'
-  'programs/vote_program/src'
+  'programs/bpf/rust'
   'programs/stake_api/src'
   'programs/stake_program/src'
+  'programs/vote_api/src'
+  'programs/vote_program/src'
 )
 
 if _ git --no-pager grep -n --max-depth=0 "${prints[@]/#/-e }" -- "${print_free_tree[@]}"; then

ci/rust-version.sh

@@ -13,11 +13,14 @@
 #   $ source ci/rust-version.sh
 #
 
-export rust_stable=1.35.0
-export rust_stable_docker_image=solanalabs/rust:1.35.0
+stable_version=1.35.0
+nightly_version=2019-06-20
 
-export rust_nightly=nightly-2019-05-01
-export rust_nightly_docker_image=solanalabs/rust-nightly:2019-05-01
+export rust_stable="$stable_version"
+export rust_stable_docker_image=solanalabs/rust:"$stable_version"
+
+export rust_nightly=nightly-"$nightly_version"
+export rust_nightly_docker_image=solanalabs/rust-nightly:"$nightly_version"
 
 [[ -z $1 ]] || (
 

ci/test-checks.sh

@@ -5,10 +5,23 @@ cd "$(dirname "$0")/.."
 
 source ci/_
 source ci/rust-version.sh stable
+source ci/rust-version.sh nightly
 
 export RUST_BACKTRACE=1
 export RUSTFLAGS="-D warnings"
 
+(
+    for project in programs/bpf/rust/*/ ; do
+    (
+        cd "$project"
+        _ cargo +"$rust_stable" fmt --all -- --check
+        _ cargo +"$rust_nightly" clippy --all -- --version
+        _ cargo +"$rust_nightly" clippy --all -- --deny=warnings
+        _ cargo +"$rust_stable" audit
+    )
+    done
+)
+
 _ cargo +"$rust_stable" fmt --all -- --check
 _ cargo +"$rust_stable" clippy --all -- --version
 _ cargo +"$rust_stable" clippy --all -- --deny=warnings