From b8816d722c732ad4cd177c73b43de569ce1625d5 Mon Sep 17 00:00:00 2001 From: Greg Fitzgerald Date: Tue, 4 Sep 2018 11:31:16 -0600 Subject: [PATCH] Fix Block::to_blobs() benchmark 16% speedup, w00t! name control ns/iter variable ns/iter diff ns/iter diff % speedup bench_block_to_blobs_to_block 29,897 25,807 -4,090 -13.68% x 1.16 --- benches/ledger.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/benches/ledger.rs b/benches/ledger.rs index c7fe169b25..c3f54edaef 100644 --- a/benches/ledger.rs +++ b/benches/ledger.rs @@ -7,7 +7,6 @@ use solana::ledger::{next_entries, reconstruct_entries_from_blobs, Block}; use solana::packet::BlobRecycler; use solana::signature::{Keypair, KeypairUtil}; use solana::transaction::Transaction; -use std::collections::VecDeque; use test::Bencher; #[bench] @@ -21,8 +20,7 @@ fn bench_block_to_blobs_to_block(bencher: &mut Bencher) { let blob_recycler = BlobRecycler::default(); bencher.iter(|| { - let mut blob_q = VecDeque::new(); - entries.to_blobs(&blob_recycler, &mut blob_q); - assert_eq!(reconstruct_entries_from_blobs(blob_q).unwrap(), entries); + let blobs = entries.to_blobs(&blob_recycler); + assert_eq!(reconstruct_entries_from_blobs(blobs).unwrap(), entries); }); }