gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

adds fallback logic if retransmit multicast fails (#17714)

Browse Source 
In retransmit-stage, based on the packet.meta.seed and resulting
children/neighbors, each packet is sent to a different set of peers:
https://github.com/solana-labs/solana/blob/708bbcb00/core/src/retransmit_stage.rs#L421-L457

However, current code errors out as soon as a multicast call fails,
which will skip all the remaining packets:
https://github.com/solana-labs/solana/blob/708bbcb00/core/src/retransmit_stage.rs#L467-L470

This can exacerbate packets loss in turbine.

This commit:
  * keeps iterating over retransmit packets for loop even if some
    intermediate sends fail.
  * adds a fallback to UdpSocket::send_to if multicast fails.

Recent discord chat:
https://discord.com/channels/428295358100013066/689412830075551748/849530845052403733
This commit is contained in:
behzad nouri
2021-06-04 12:16:37 +00:00
committed by GitHub
parent bea7ce717c
commit be957f25c9
3 changed files with 23 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/retransmit_stage.rs
View File

@ -465,9 +465,9 @@ fn retransmit(
let mut retransmit_time = Measure::start("retransmit_to");
if !packet.meta.forward {
ClusterInfo::retransmit_to(&neighbors, packet, sock, true)?;
ClusterInfo::retransmit_to(&neighbors, packet, sock, true);
}
ClusterInfo::retransmit_to(&children, packet, sock, packet.meta.forward)?;
ClusterInfo::retransmit_to(&children, packet, sock, packet.meta.forward);
retransmit_time.stop();
retransmit_total += retransmit_time.as_us();
}