Ban Default::default()
This commit is contained in:
15
ci/nits.sh
15
ci/nits.sh
@ -7,7 +7,7 @@ set -e
|
|||||||
cd "$(dirname "$0")/.."
|
cd "$(dirname "$0")/.."
|
||||||
source ci/_
|
source ci/_
|
||||||
|
|
||||||
# please don't print from --lib...
|
# Logging hygiene: Please don't print from --lib, use the `log` crate instead
|
||||||
declare prints=(
|
declare prints=(
|
||||||
'print!'
|
'print!'
|
||||||
'println!'
|
'println!'
|
||||||
@ -15,7 +15,16 @@ declare prints=(
|
|||||||
'eprintln!'
|
'eprintln!'
|
||||||
)
|
)
|
||||||
|
|
||||||
if _ git grep "${prints[@]/#/-e }" src
|
if _ git grep "${prints[@]/#/-e }" src; then
|
||||||
then
|
|
||||||
exit 1
|
exit 1
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
|
||||||
|
# Code readability: please be explicit about the type instead of using
|
||||||
|
# Default::default()
|
||||||
|
#
|
||||||
|
# Ref: https://github.com/solana-labs/solana/issues/2630
|
||||||
|
if _ git grep 'Default::default()' -- '*.rs'; then
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user