bank.withdraw uses checked_sub_lamports (#16848)

* bank.withdraw uses checked_sub_lamports * retain previous codepath for error * map_err from clippy
2021-04-27 09:58:41 -05:00 · 2021-04-27 09:58:41 -05:00 · d533f77301
commit d533f77301
parent 69bfbf9e98
1 changed files with 3 additions and 2 deletions
--- a/runtime/src/bank.rs
+++ b/runtime/src/bank.rs
@ -4034,8 +4034,9 @@ impl Bank {
                    .checked_add(min_balance)
                    .filter(|required_balance| *required_balance <= account.lamports())
                    .ok_or(TransactionError::InsufficientFundsForFee)?;
-
-                account.lamports -= lamports;
+                account
+                    .checked_sub_lamports(lamports)
+                    .map_err(|_| TransactionError::InsufficientFundsForFee)?;
                self.store_account(pubkey, &account);

                Ok(())